-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #2968 to add write
argument to get.trait.data()
and friends
#3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should I add a |
Looks like test coverage for these functions is 0%, but I did install this PR and test with an existing run and the behavior is correct. Not sure how to write tests for database stuff, but I can try if you'd like. |
dlebauer
approved these changes
Jan 10, 2023
Aariq
added
Status: Ready
Pull request ready for merge, or issue ready to be closed
and removed
Status: Review required
labels
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
write
argument toget.trait.data()
andget.trait.data.pft()
and changesrunModule.get.trait.data()
andget.trait.data()
to correctly pass thewrite
argument. Minor fixes to documentation, code formatting, and fixed one unrelated check warning insite.pft.link.settings()
Motivation and Context
Closes #2968
Review Time Estimate
Types of changes
Checklist: