Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #2968 to add write argument to get.trait.data() and friends #3065

Merged
merged 14 commits into from
Jan 11, 2023

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Nov 10, 2022

Description

Adds a write argument to get.trait.data() and get.trait.data.pft() and changes runModule.get.trait.data() and get.trait.data() to correctly pass the write argument. Minor fixes to documentation, code formatting, and fixed one unrelated check warning in site.pft.link.settings()

Motivation and Context

Closes #2968

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Aariq
Copy link
Collaborator Author

Aariq commented Nov 10, 2022

Should I add a NEWS.md to the settings package and bump the version?

@Aariq
Copy link
Collaborator Author

Aariq commented Nov 10, 2022

Looks like test coverage for these functions is 0%, but I did install this PR and test with an existing run and the behavior is correct. Not sure how to write tests for database stuff, but I can try if you'd like.

@Aariq Aariq added Status: Ready Pull request ready for merge, or issue ready to be closed and removed Status: Review required labels Jan 10, 2023
@mdietze mdietze merged commit 9a8589d into develop Jan 11, 2023
@Aariq Aariq deleted the trait-write-bety branch January 11, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready Pull request ready for merge, or issue ready to be closed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<bety><write> tag not respected by get.trait.data()
3 participants