Fixed remaining Notes in PEcAn.MA #2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlebauer
requested changes
Jul 21, 2022
infotroph
requested changes
Jul 22, 2022
Co-authored-by: Chris Black <chris@ckblack.org>
|
@nanu1605 this pr is passing checks. If you address the changes requested by @dlebauer and @infotroph i'd be happy to pull it in |
|
Hi @mdietze, I have done the changes requested by @infotroph and @dlebauer but let them review it once before pulling it in |
|
@nanu1605 let's update the CHANGELOG as part of this PR and have Rcheck_reference be its own PR. Reasoning: It's much easier to write down what changed when you're looking at the changeset from the PR than later, whereas the Rcheck_reference updates are essentially cleanup operations. |
|
@infotroph @dlebauer have the changes you both requested been addressed? |
infotroph
requested changes
Jul 31, 2022
Co-authored-by: Chris Black <chris@ckblack.org>
infotroph
reviewed
Jul 31, 2022
infotroph
approved these changes
Jul 31, 2022
dlebauer
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.