-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix current_user_can_use_pch_feature() issues #2723
Fix current_user_can_use_pch_feature() issues #2723
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (4)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
Description
This PR fixes a couple of issue in the
Permissions::current_user_can_use_pch_feature()
function. Notably:wp_parsely_current_user_can_use_pch_feature
filter.wp_parsely_current_user_can_use_pch_feature
filter had no effect when the feature in question was disabled.Motivation and context
Improve function behavior and make it return the results we expect.
How has this been tested?
The issues above were discovered while writing tests for the
Permissions
class. These need a final look and will be introduced in a PR very soon. They are to be released as part of 3.17.0.