Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some untranslatable strings #2612

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Jul 8, 2024

Description

With this PR, we're fixing a couple of untranslatable strings we found.

Motivation and context

Being able to translate as many strings as possible.

How has this been tested?

Untested.

Summary by CodeRabbit

  • Enhancements
    • Updated settings panel titles to support translation for better localization.
    • Improved accessibility for non-English users by translating the "Settings" and "Excerpt" titles.

Copy link
Contributor

coderabbitai bot commented Jul 8, 2024

Walkthrough

Walkthrough

The overall changes enhance the internationalization (i18n) support for the project by updating the title attributes of the PanelBody and PluginDocumentSettingPanel components to use a translation function instead of static strings. This change ensures that these components' titles are translatable and can be adapted for different languages.

Changes

File Path Change Summary
src/blocks/recommendations/components/parsely-recommendations-inspector-controls.tsx Updated the title attribute of the PanelBody component to use a translated string.
src/content-helper/excerpt-generator/components/excerpt-panel.tsx Updated the title attribute of the PluginDocumentSettingPanel component to use a translation function.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@acicovic acicovic marked this pull request as ready for review July 8, 2024 08:28
@acicovic acicovic requested a review from a team as a code owner July 8, 2024 08:28
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 500ae12 and 80bd684.

Files ignored due to path filters (4)
  • build/blocks/recommendations/edit.asset.php is excluded by !build/**
  • build/blocks/recommendations/edit.js is excluded by !build/**
  • build/content-helper/excerpt-generator.asset.php is excluded by !build/**
  • build/content-helper/excerpt-generator.js is excluded by !build/**
Files selected for processing (2)
  • src/blocks/recommendations/components/parsely-recommendations-inspector-controls.tsx (1 hunks)
  • src/content-helper/excerpt-generator/components/excerpt-panel.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/blocks/recommendations/components/parsely-recommendations-inspector-controls.tsx
  • src/content-helper/excerpt-generator/components/excerpt-panel.tsx

@acicovic acicovic merged commit 7db49de into develop Jul 8, 2024
36 checks passed
@acicovic acicovic deleted the fix/some-untranslatable-strings branch July 8, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants