Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCH Smart Linking: Implement Smart Links Reviewing step #2507

Merged
merged 57 commits into from
Jun 6, 2024
Merged
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
82f7209
Add optional `$request` parameter to `is_available_to_current_user`
vaurdan Apr 4, 2024
a8dc5a8
Lower phpstan type coverage param_type to 79.7
vaurdan Apr 4, 2024
3751f4d
Add Smart Linking models and bare endpoint
vaurdan Apr 5, 2024
6080cea
Merge branch 'refs/heads/develop' into add/smart-linking-links-review
vaurdan Apr 29, 2024
3f8cd9b
Start implementing Modal UI
vaurdan Apr 30, 2024
47a1daf
Implement preview and UI elements
vaurdan May 2, 2024
c8f2f55
Finalize modal with apply and reject actions
vaurdan May 6, 2024
ea5059f
Add Remove Link and Select in Editor buttons
vaurdan May 6, 2024
b8a91f7
Backend improvements
vaurdan May 6, 2024
163e0a2
Improve functionality for existing smart links
vaurdan May 7, 2024
c36f2c2
Add max-height to the sidebar
vaurdan May 7, 2024
f89dedb
Fix issue with the onClose callback of the modal
vaurdan May 7, 2024
dd15dfb
Sort smart links by block position and offset
vaurdan May 7, 2024
1e7c34b
Merge branch 'refs/heads/develop' into add/smart-linking-links-review
vaurdan May 13, 2024
adaa026
Rebuild assets
vaurdan May 13, 2024
52461a4
Rebuild assets
vaurdan May 13, 2024
a39561c
Implement getting existing smart links to populate the modal
vaurdan May 13, 2024
a6b0314
Improve modal sidebar scrolling when navigating the smart links
vaurdan May 14, 2024
3056819
Implement retrieval of the post type for each smart link
vaurdan May 14, 2024
646ac8e
Improve sorting and backfilling of existing smart links data
vaurdan May 15, 2024
411e313
Better smart link detection and auto-fixing on save, link removal, an…
vaurdan May 17, 2024
a587087
Move isReviewModalOpen to the store to be global across the Smart Lin…
vaurdan May 17, 2024
fb10bd2
Add tooltip to the modal actions
vaurdan May 20, 2024
0aeffc4
Clean-up code and documentation
vaurdan May 20, 2024
0aaab89
Implement the link selection functionality
vaurdan May 20, 2024
5ca91ec
UI & functionality tweaks to the Link Details component
vaurdan May 20, 2024
203ef63
Rebuild assets with the "finalized" UI & fix linting
vaurdan May 20, 2024
2cd2abe
Merge branch 'refs/heads/develop' into add/smart-linking-links-review
vaurdan May 20, 2024
76ad877
Rebuild assets & fix tests
vaurdan May 20, 2024
7b882f9
Fix some issues with link validation and saving
vaurdan May 21, 2024
6d9606c
Address issue with sorting in some edge cases
vaurdan May 22, 2024
72d9292
Apply code review suggestions
vaurdan May 22, 2024
470e5cb
Apply suggestions from code review
vaurdan May 22, 2024
20ee2da
Merge branch 'refs/heads/develop' into add/smart-linking-links-review
vaurdan May 22, 2024
e2d1b00
Rebuild assets
vaurdan May 22, 2024
2d49f52
Merge remote-tracking branch 'origin/add/smart-linking-links-review' …
vaurdan May 22, 2024
2f11932
Merge branch 'develop' into add/smart-linking-links-review
acicovic May 23, 2024
c2ffc6a
class-smart-linking-endpoint.php: Improve comments
acicovic May 23, 2024
edac118
Fix regression with getBlockContent
vaurdan May 23, 2024
271631e
Merge remote-tracking branch 'origin/add/smart-linking-links-review' …
vaurdan May 23, 2024
45f1d91
Apply suggestions from code review
vaurdan May 23, 2024
9de4b08
Update src/Endpoints/class-base-endpoint.php
vaurdan May 23, 2024
ca7d094
Performance improvement per code review suggestion.
vaurdan May 23, 2024
c2a173d
Improve comments in some PHP files
acicovic May 23, 2024
cce7044
Merge branch 'add/smart-linking-links-review' of github.com:Parsely/w…
acicovic May 23, 2024
b53ff0e
Smart Linking Provider: Improve comments
acicovic May 23, 2024
2e870bb
Apply whitespace and comment improvements
acicovic May 24, 2024
0df2899
Apply whitespace and comment improvements
acicovic May 24, 2024
bfa96fb
Apply comment improvements
acicovic May 24, 2024
91a3afe
Merge branch 'refs/heads/develop' into add/smart-linking-links-review
vaurdan Jun 4, 2024
017e177
Rebuild assets
vaurdan Jun 4, 2024
2a9f29e
Apply code review suggestions from @acicovic
vaurdan Jun 4, 2024
3b8b2c3
Merge branch 'develop' into add/smart-linking-links-review
acicovic Jun 4, 2024
e8ee9ea
Merge branch 'develop' into add/smart-linking-links-review
acicovic Jun 6, 2024
a29a4f6
Merge branch 'develop' into add/smart-linking-links-review
acicovic Jun 6, 2024
f2ef3f0
Fix tests (hopefully)
vaurdan Jun 6, 2024
7dc50b7
Merge branch 'develop' into add/smart-linking-links-review
vaurdan Jun 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/admin-settings-rtl.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/admin-settings.asset.php
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array(), 'version' => 'e15999c17e352b22474b');
<?php return array('dependencies' => array(), 'version' => '20eafa29410328a029a2');
2 changes: 1 addition & 1 deletion build/admin-settings.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/content-helper/dashboard-widget-rtl.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion build/content-helper/dashboard-widget.asset.php
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n', 'wp-url'), 'version' => '930369a3015a8fbd0eee');
<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-data', 'wp-element', 'wp-i18n', 'wp-url'), 'version' => '2a085e2f1803cbb45764');
Loading