Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCH Editor Sidebar: Update isDismissible in Notices #2428

Merged
merged 3 commits into from
Apr 24, 2024
Merged

PCH Editor Sidebar: Update isDismissible in Notices #2428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b657485
PCH Editor Sidebar: Update isDismissible in Notices
acicovic Apr 24, 2024
4078f33
Merge branch 'develop' into update/isdismissible-in-notices-in-pch-ed…
acicovic Apr 24, 2024
376be18
Merge branch 'develop' into update/isdismissible-in-notices-in-pch-ed…
acicovic Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/content-helper/editor-sidebar.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => '878a086ea69d7acfeb3a');
<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-block-editor', 'wp-components', 'wp-compose', 'wp-core-data', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url'), 'version' => '7cda9ce01084868d6502');
18 changes: 9 additions & 9 deletions build/content-helper/editor-sidebar.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion build/content-helper/excerpt-generator.asset.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url', 'wp-wordcount'), 'version' => '969ccb836b949526cd4c');
<?php return array('dependencies' => array('react', 'wp-api-fetch', 'wp-components', 'wp-data', 'wp-edit-post', 'wp-editor', 'wp-element', 'wp-hooks', 'wp-i18n', 'wp-plugins', 'wp-primitives', 'wp-url', 'wp-wordcount'), 'version' => 'c414a07c1ac7aaf41cff');
4 changes: 2 additions & 2 deletions build/content-helper/excerpt-generator.js
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion src/content-helper/editor-sidebar/related-posts/component-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export const RelatedPostItem = (
__( 'URL copied to clipboard', 'wp-parsely' ),
{
type: 'snackbar',
isDismissible: true,
}
);
} );
Expand Down
4 changes: 0 additions & 4 deletions src/content-helper/editor-sidebar/smart-linking/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,6 @@ export const SmartLinkingPanel = ( {
await setError( e );
createNotice( 'error', snackBarMessage, {
type: 'snackbar',
isDismissible: true,
} );
} finally {
await setLoading( false );
Expand Down Expand Up @@ -397,7 +396,6 @@ export const SmartLinkingPanel = ( {
sprintf( __( '%s smart links successfully applied.', 'wp-parsely' ), numberOfUpdatedLinks ),
{
type: 'snackbar',
isDismissible: true,
},
);
};
Expand Down Expand Up @@ -676,7 +674,6 @@ export const SmartLinkingPanel = ( {
{ error && (
<Notice
status="info"
isDismissible={ true }
onRemove={ () => setError( null ) }
acicovic marked this conversation as resolved.
Show resolved Hide resolved
className="wp-parsely-content-helper-error"
>
Expand All @@ -686,7 +683,6 @@ export const SmartLinkingPanel = ( {
{ suggestedLinks !== null && (
<Notice
status="success"
isDismissible={ true }
onRemove={ () => setSuggestedLinks( null ) }
acicovic marked this conversation as resolved.
Show resolved Hide resolved
className="wp-parsely-smart-linking-suggested-links"
>
Expand Down
3 changes: 1 addition & 2 deletions src/content-helper/editor-sidebar/title-suggestions/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,6 @@ export const TitleSuggestionsPanel = (): JSX.Element => {
{
type: 'snackbar',
className: 'parsely-title-suggestion-error',
isDismissible: true,
}
);
}, [ error ] ); // eslint-disable-line react-hooks/exhaustive-deps
Expand Down Expand Up @@ -247,7 +246,7 @@ export const TitleSuggestionsPanel = (): JSX.Element => {
</Button>
</div>
{ error && (
<Notice status="info" isDismissible={ false } className="wp-parsely-content-helper-error">
<Notice status="info" className="wp-parsely-content-helper-error">
{ error.Message() }
</Notice>
) }
Expand Down
1 change: 0 additions & 1 deletion src/content-helper/excerpt-generator/components/excerpt-panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ const PostExcerptGenerator = () => {
{ error && (
<Notice
status="info"
isDismissible={ false }
className="wp-parsely-excerpt-generator-error"
>
{ error.Message() }
Expand Down