Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCH Smart Linking: Fix issues with undo functionality and link offsets #2315

Merged
merged 10 commits into from
Mar 22, 2024

Conversation

vaurdan
Copy link
Contributor

@vaurdan vaurdan commented Mar 21, 2024

Description

This PR fixes a few issues with the PCH Smart Linking:

  • As reported in PCH Smart Linking: Undo doesn't work for All Blocks option #2313, the undo was not working properly to revert the applied links in the full content. This has been addressed and CTRL/cmd + z should remove all the applied links.
  • FIxed an issue when applying multiple links with the same text and different offsets.
  • Improved the success notice and Snackbar to show the actual number of added links, instead of the number of link suggestions. The notice is now dismissible as well.

Motivation and context

Improve the reliability of the Smart Linking feature and the user experience when working with this feature.

How has this been tested?

Tested locally, with a specific link suggestions payload that included three suggestions with the same text, but three different offsets.

@vaurdan vaurdan added this to the 3.14.3 milestone Mar 21, 2024
@vaurdan vaurdan self-assigned this Mar 21, 2024
@vaurdan vaurdan requested a review from a team as a code owner March 21, 2024 15:16
@vaurdan vaurdan merged commit 4964820 into develop Mar 22, 2024
36 checks passed
@vaurdan vaurdan deleted the fix/smart-linking-fixes branch March 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant