PCH: Fix issue with common styles not being correctly bundled #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acicovic
approved these changes
Mar 18, 2024
vaurdan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the merge of #2289, an issue with the way the
common.scssfile is bundled was introduced. This prevented some critical common styles from being loaded, creating some unexpected UI bugs, such as the ones identified and addressed in #2296 (error notices with wrong paddings and margins).Motivation and context
Fix the current issues with PCH UI styles.
How has this been tested?
Tested locally and gone through all the PCH components to make sure that they are correctly stylized. I also validated that the error messages have the correct margins.
Screenshots (if appropriate)