Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCH Editor Sidebar: Fix some UI glitches #2288

Merged
merged 6 commits into from
Mar 13, 2024
Merged

PCH Editor Sidebar: Fix some UI glitches #2288

merged 6 commits into from
Mar 13, 2024

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Mar 13, 2024 •
edited
Loading

Description

  • Fixes a large blank space above errors in Performance Stats.
  • Fixes the zero margin that was happening for the "Contac Us" message in Performance Stats. This fix will also catch any error messages that could be displayed there.
  • Fixes the incorrect "Regenerate Excerpt" text that would appear in the Excerpt Generator in some cases.
  • Improves the styling of the Excerpt Generator notice.

Motivation and context

  • Improve UI/UX

How has this been tested?

  • Manually verified that adjustments work as expected.
  • Automated tests pass.

Screenshots

Before After
image image
image image
image image

@acicovic acicovic self-assigned this Mar 13, 2024
@acicovic acicovic added this to the 3.14.1 milestone Mar 13, 2024
@acicovic acicovic marked this pull request as ready for review March 13, 2024 11:41
@acicovic acicovic requested a review from a team as a code owner March 13, 2024 11:41
vaurdan
vaurdan approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@vaurdan vaurdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these improvements! Looks great!

@acicovic acicovic merged commit 316015a into develop Mar 13, 2024
35 checks passed
@acicovic acicovic deleted the fix/some-pch-editor-sidebar-ui-glitches branch March 13, 2024 14:43
@vaurdan vaurdan mentioned this pull request Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaurdan vaurdan vaurdan approved these changes

Assignees

@acicovic acicovic

Labels
Changelog: Fixed Feature: Content Helper
Projects
None yet
Milestone
3.14.1
Development

Successfully merging this pull request may close these issues.
2 participants
@acicovic @vaurdan