Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata: Add filter for custom taxonomies #1995

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

norcross
Copy link
Contributor

@norcross norcross commented Nov 9, 2023

Description

This change adds a filter to the array of non-default (i.e. custom) taxonomies being passed.

Motivation and context

Currently, the option to include categories into the larger array is an "all or nothing" choice. many site used custom taxonomies for reasons that don't require being included, much like the existing core function that removes the author taxonomy added by Co-Authors Plus.

this PR is in response to this: #1970 (a coworker of mine)

How has this been tested?

We tested these changes locally and on our VIP environments, and have deployed a similar fix to our production site.
This was run using the most current version of the plugin (3.10.0)

@norcross norcross requested a review from a team as a code owner November 9, 2023 18:57
Copy link
Collaborator

@acicovic acicovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

src/Metadata/class-post-builder.php Outdated Show resolved Hide resolved
src/Metadata/class-post-builder.php Outdated Show resolved Hide resolved
src/Metadata/class-post-builder.php Outdated Show resolved Hide resolved
@acicovic acicovic added this to the 3.11.0 milestone Nov 10, 2023
@acicovic acicovic changed the title adding new filter for custom taxonomies Metadata: Add filter for custom taxonomies Nov 13, 2023
@acicovic
Copy link
Collaborator

@norcross, this will become available in the 3.11.0 release.

@acicovic acicovic merged commit 6f738b5 into Parsely:develop Nov 13, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants