Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Helper: Add more period filters #1922

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

acicovic
Copy link
Collaborator

@acicovic acicovic commented Oct 13, 2023

Description

This PR refactors code related to Period so additional periods can be added to the Content Helper. Changes affect the PCH Dashboard Widget and Sidebar.

With this change, the periods supported are as follows:

  • Last 10 Minutes
  • Last Hour
  • Last 2 Hours
  • Last 4 Hours
  • Last 24 Hours
  • Last 7 Days
  • Last 30 Days

Motivation and context

Provide more options regarding the data we're displaying in the Content Helper.

How has this been tested?

Existing tests pass and a slight test modification was made.

@acicovic acicovic added this to the 3.11.0 milestone Oct 13, 2023
@acicovic acicovic self-assigned this Oct 13, 2023
@acicovic acicovic marked this pull request as ready for review October 13, 2023 09:36
@acicovic acicovic requested a review from a team as a code owner October 13, 2023 09:36
@acicovic acicovic merged commit 5ed6593 into develop Oct 13, 2023
37 checks passed
@acicovic acicovic deleted the add/more-period-filters-to-the-content-helper branch October 13, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants