Validate API credentials using the Parse.ly API validation endpoint

[vaurdan]

Description

Validate the API credentials by doing a API request to the validation endpoint. This assures that only valid credentials can be saved on the Settings page.

Motivation and context

Fixes #1853

How has this been tested?

Tested on my local environment and with three new integration tests.

Screenshots (if appropriate)

[vaurdan]

Adding a "Do Not Merge" label as there is a problem with the e2e tests that need to be addressed. Looking into it.

[vaurdan]

Removing the Do Not Merge label as the E2E issues were addressed.

The issue was with testing with API credentials that aren't valid, since those are checked against the validate endpoint. I added a GET parameter called e2e_parsely_skip_api_validate that when is present in the settings page and set to y, it should skip the HTTP request to the validate endpoint and assume they are correct.

[acicovic]

Hey there! Thank you for your work!

I haven't looked into the code just yet, but using the UI I noticed that it seems the settings page won't allow saving an empty Site ID or API Secret, which should be possible (especially for the API Secret since not all customers may have API access). You can easily see this if you've got a filled API Secret and then try to empty it.

I'd suggest looking how develop behaves with saving empty credentials and replicate the same behavior in this branch, unless we've got a reason to change it. In this case we can discuss it! 🙂

[vaurdan]

@acicovic ah nice catch. I had it working like that previously but I think I accidentally reverted it when I amended a commit. Pushed the changes that should allow empty Site ID and Secret :)

[acicovic]

Excellent work! The effort that you've made to stick to project conventions is apparent and greatly appreciated!

Left some questions and a couple of minor adjustment proposals. This review is extremely super picky by the way and mostly focuses on details that are trivial.

Thank you so much!

[acicovic]

@vaurdan, I had a second look. Thanks for addressing the feedback and replying. If you agree to wipe out the non-API validations, please go ahead and I can take a final look.

Thanks! 🙂

[vaurdan]

@acicovic the older methods have been removed in favor of the new validate_api_credentials. Let me know your thoughts and feedback!

[acicovic]

Great work! Left some comments and questions, mostly details.

[acicovic]

Thanks for working on this and bearing with me 🙂