Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a reasonable size of the backlog for the extension server socket #36

Merged
merged 1 commit into from
May 23, 2023

Conversation

EmilioPeJu
Copy link
Contributor

Since python 3.5, the backlog parameter is optional and it will
use a default reasonable value. Using value 0 was causing the
following message in linux logs:
TCP: request_sock_TCP: Possible SYN flooding on port 9999...

@EmilioPeJu
Copy link
Contributor Author

EmilioPeJu commented May 22, 2023

As a curiosity, a value of 0 is used in combination with having /proc/sys/net/ipv4/tcp_syncookies set to 1, that means the kernel doesn't save any state for sockets that only has received a SYN flagged packet.... however, this is not useful in our case, the extension server usually has 1 connection from the panda server, which means we don't have to worry about receiving too many SYN packets at once

Using value 0 was causing the following message in linux logs:
TCP: request_sock_TCP: Possible SYN flooding on port 9999...
@EmilioPeJu
Copy link
Contributor Author

EmilioPeJu commented May 23, 2023

After some investigation, I can say that It's not clear what's the meaning of value 0, it seems like a "supported" bug

@Araneidae Araneidae merged commit c104c0a into master May 23, 2023
@EmilioPeJu EmilioPeJu deleted the fix-syn-flood branch May 23, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants