Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for compatibility with Vivado2022.2 kernel #35

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Changes for compatibility with Vivado2022.2 kernel #35

merged 1 commit into from
Apr 19, 2023

Conversation

glennchid
Copy link
Contributor

No description provided.

EmilioPeJu
EmilioPeJu approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@EmilioPeJu EmilioPeJu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, an alternative way to deal with the warning is by temporarily disabling it around the include causing the problem by using GCC pragmas, though that approach seems less clean

@Araneidae
Copy link
Contributor

A couple of comments, but I'm happy to accept this change.

I would have liked to see the actual error message that forced us to remove the -Wtype-limits check. However, this is kernel code only, so I am less concerned about keeping all the gcc warnings.

I found the patch that removes MODULE_SUPPORTED_DEVICE, seems this was a couple of years ago now: remove never implemented MODULE_SUPPORTED_DEVICE.

@tomtrafford tomtrafford merged commit a9c6ea9 into master Apr 19, 2023
@tomtrafford tomtrafford deleted the vivado2022_2 branch April 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilioPeJu EmilioPeJu EmilioPeJu approved these changes

@Araneidae Araneidae Awaiting requested review from Araneidae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@glennchid @Araneidae @EmilioPeJu @tomtrafford