Robustify mission upload/download #8750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix mission upload and download with QGC on a lossy link. The way it should work according to the protocol on https://mavlink.io/en/protocol/mission.html is that in general the ground station should be concerned about timeouts and retransmission. This means the autopilot does not need to retransmit by itself but just answer requests. This seems like it would make the transfer less robust, however, it actually resolves an edge case where QGC fails to make requests because it gets spammed by the autopilot and keeps resetting the timeout.
When we receive a MAV_MISSION_UNSUPPORTED, we should try to send a mission request again with or without int mode.
if anything doesn't go according to protocol we should not just throw warnings but actually tell the ground station with a mission nack.
Instead of using a timeout to resend a mission item, we should directly send the mission request again. This is needed because we removed the automatic resending which lead to troubles.
julianoes
force-pushed
the
fix-mission-upload-download
branch
from
d5688cf
to
423ca3a
Compare
julianoes
changed the title
This was referenced Jan 24, 2018
LorenzMeier
approved these changes
Jan 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few changes in order to make the mission upload and download with QGC and DroneCore more robust (and also faster) on a lossy link.
The changes go together with mavlink/qgroundcontrol#6059.
This PR is mostly done but I need to test compatibility between QGC without the recent PR and also QGC with the recent PR and Firmware without this PR.Tested against latest QGC release, upload/download works.