README: Update minimum PHPCS version requirement and composer install instructions #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n requirement PR 687 raised the minimum supported PHPCS 2.x version to `2.3.0` in the `composer.json`. This should also be reflected in the information in the Readme. Also: as PHPCS is a dependency of PHPCompatibility, people shouldn't add it to their `require-dev`, but should leave it up to PHPCompatibility to require it. [ci skip]
jrfnl
added
documentation
PR: quick merge
wimg
approved these changes
Jul 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #687 raised the minimum supported PHPCS 2.x version to
2.3.0in thecomposer.json. This should also be reflected in the information in the Readme.Also: as PHPCS is a dependency of PHPCompatibility, people shouldn't add it to their
require-dev, but should leave it up to PHPCompatibility to require it.[ci skip]
N.B.: I'm aware that this PR will have an imaginary conflict with PR #689, so just ping me and I'll rebase either one depending on which one gets merged first.