Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding some more unit tests for PHPCompatibility_Sniff::getTestVersion() #405

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Adding some more unit tests for PHPCompatibility_Sniff::getTestVersion() #405

merged 1 commit into from
Apr 26, 2017

Conversation

MarkMaldaba
Copy link
Contributor

  • Some tests for ranges containing white-space.
  • Some tests for invalid ranges.

@MarkMaldaba
Adding some more unit tests for PHPCompatibility_Sniff::getTestVersio…
eb4da61 
…n().

* Some tests for ranges containing white-space.
* Some tests for invalid ranges.
@MarkMaldaba MarkMaldaba mentioned this pull request Apr 14, 2017
Merged
@coveralls
Copy link

coveralls commented Apr 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 95.897% when pulling eb4da61 on MarkMaldaba:testversion_partial_ranges into aabac47 on wimg:master.

@wimg wimg merged commit 51ccc10 into PHPCompatibility:master Apr 26, 2017
@jrfnl jrfnl added this to the 7.1.4 milestone May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfnl jrfnl jrfnl approved these changes

Assignees
No one assigned
Labels
chores/QA
Projects
None yet
Milestone
7.1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@MarkMaldaba @coveralls @jrfnl @wimg