Merge pull request #465 from wimg/bugfix-fp-deprecatedfunction-class

False positive on deprecated functions after class definition - Fixes #464
PHPCompatibility · Jun 14, 2017 · 5d42644 · 5d42644
2 parents be16e59 + ff96d19
commit 5d42644
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/Sniffs/PHP/DeprecatedFunctionsSniff.php b/Sniffs/PHP/DeprecatedFunctionsSniff.php
@@ -796,6 +796,7 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
             T_DOUBLE_COLON,
             T_OBJECT_OPERATOR,
             T_FUNCTION,
+            T_CLASS,
             T_CONST,
             T_USE,
             T_NS_SEPARATOR,

diff --git a/Tests/Sniffs/PHP/DeprecatedFunctionsSniffTest.php b/Tests/Sniffs/PHP/DeprecatedFunctionsSniffTest.php
@@ -192,8 +192,8 @@ public function dataDeprecatedFunctionWithAlternative()
             array('mcrypt_module_self_test', '7.1', 'OpenSSL', array(130), '7.0'),
             array('mdecrypt_generic', '7.1', 'OpenSSL', array(131), '7.0'),
 
-            array('jpeg2wbmp', '7.2', 'imagecreatefromjpeg() and imagewbmp()', array(143), '7.1'),
-            array('png2wbmp', '7.2', 'imagecreatefrompng() or imagewbmp()', array(144), '7.1'),
+            array('jpeg2wbmp', '7.2', 'imagecreatefromjpeg() and imagewbmp()', array(144), '7.1'),
+            array('png2wbmp', '7.2', 'imagecreatefrompng() or imagewbmp()', array(145), '7.1'),
         );
     }
 

diff --git a/Tests/sniff-examples/deprecated_functions.php b/Tests/sniff-examples/deprecated_functions.php
@@ -138,6 +138,7 @@
 const php_check_syntax;
 use php_check_syntax;
 function php_check_syntax() {}
+abstract class Split {}
 
 // More deprecated functions, PHP 7.2
 jpeg2wbmp();