CS: Add PHP 5.3 compatibility #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of short syntax for arrays was the only thing stopping this package from being compatible with PHP 5.3 as well. This makes it usable for more authors (such as those in the WordPress community).
GaryJones
force-pushed
the
5.3-compatibility
branch
from
660133f
to
fbd8107
Compare
Merged
|
Since this package does not use any explicit PHP 7.0 or 7.1 features, I think it would be sensible to follow the version constraint set by Composer. |
|
@frenck Any feedback on this? Here's an example of a failing Travis build which is now stopping PRs from being merged.
|
54 tasks
Potherca
approved these changes
Sep 16, 2017
|
Unlike the VersionEye check that failed in PR-38, this check fails because of License whitelist issues.
I've added the PHP license to the whitelist. I've Triggered the check again by finding the payload in the Webhooks Settings and pressing the ↻ Redeliver button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically follows on from #38, though isn't strictly dependent on it being merged.
The use of short syntax for arrays was the only thing stopping this package from being compatible with PHP 5.3 as well. PHP 5.3 is specified in the Travis CI config. Allowing it to be used in setups that require PHP 5.3 makes it usable for more authors (such as those in the WordPress community).
Composer also requires PHP 5.3.2 to run, so it makes sense to ensure it works with that too.