Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayNiceWithScriptsTest: wrap output expectation in condition #179

Merged
merged 2 commits into from
May 25, 2022

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Apr 18, 2022

Proposed Changes

Yet another one which intermittently fails on the notorious PHP 5.5 / Composer 1.x on Windows combination.
(saw it fail in two of the test runs for the new PRs, though, like in most cases: not always)

@jrfnl jrfnl requested a review from a team April 18, 2022 23:44
@jrfnl jrfnl force-pushed the feature/playnicewithscripts-test-fix-flacky-php-55-win branch from 55f03ef to 8d39be8 Compare April 19, 2022 00:55
... to allow the function to be called from data providers.
@jrfnl jrfnl force-pushed the feature/playnicewithscripts-test-fix-flacky-php-55-win branch from 8d39be8 to 70d65b6 Compare April 19, 2022 01:46
Yet another one which fails on the notorious PHP 5.5 / Composer 1.x on Windows combination.
@jrfnl jrfnl force-pushed the feature/playnicewithscripts-test-fix-flacky-php-55-win branch from 70d65b6 to f0251b8 Compare April 19, 2022 02:03
@jrfnl jrfnl merged commit aa70e1c into master May 25, 2022
@jrfnl jrfnl deleted the feature/playnicewithscripts-test-fix-flacky-php-55-win branch May 25, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants