RDEV-5995 Support for webpack 5 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvesmiguel1
commented
Sep 27, 2023
mpm-os
reviewed
Oct 20, 2023
ViewGenerator/tools/webpack/Plugins/ForkTsCheckerWebpackFormatterPlugin.ts
Outdated
Show resolved
Hide resolved
mpm-os
approved these changes
Oct 20, 2023
osesantos
approved these changes
Oct 20, 2023
| @@ -1,84 +1,44 @@ | |||
| import { basename } from "path"; | |||
| import { RuleSetRule } from "webpack"; | |||
| import { AssetInfo, NormalModule, PathData, RuleSetRule } from "webpack"; | |||
There was a problem hiding this comment.
will these changes fix the hack we have on the framework to have the web components packages available in that project?
There was a problem hiding this comment.
Which hack? 😅 the webview.plugins symlink?
There was a problem hiding this comment.
If so, I haven't changed that
There was a problem hiding this comment.
after the pnpm we had to have direct references on the package.json of the Framework because of this File.ts
There was a problem hiding this comment.
we need to test this, I'm not convinced it will fix it..
There was a problem hiding this comment.
Yep, I do not think it will fix it... But I have some ideas that we can leverage afterwards
OS-sandeeppal
approved these changes
Oct 20, 2023
joaompneves
reviewed
Oct 23, 2023
|
@joaompneves I'll address your comments in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade webpack and its plugins from v4 to v5, and dealing with breaking changes.