RMET-2046 SQLite 3.33.0 update - iOS #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and cover issue in documentation
NOTE: Jasmine 2.6.0 and newer reports uncaught errors on some tests on HTML5 (WebKit) Web SQL tests (FUTURE TBD for further investigation)
- Mark some Android errors as internal plugin errors (quick fix) - remove trailing whitespace from Android implementation - quick doc updates - test coverage updates included
per string test case, removed from another place ref: storesafe/cordova-sqlite-storage#564
old QUnit-like utility functions removed from this test script
Additional test ref: storesafe/cordova-sqlite-storage#791
(in custom build, as documented)
nflsilva
requested review from
alexgerardojacinto,
felipecn,
hectorjdgdev,
OS-martacarlos and
OS-ricardomoreirasilva
nflsilva
changed the title
* feat: updated jars * updated jars * feat: updated gitignore. added db migration * feat: added database migration * fix: added migration code. * chore: updated changelog
OS-ricardomoreirasilva
approved these changes
Dec 21, 2022
|
Don't forget the entry on the |
OS-martacarlos
approved these changes
Dec 21, 2022
alexgerardojacinto
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
Description
To accomplish this update, we started by pulling all the updates from upstream repo and solving the needed conflicts.
-- We knew which changes to pull based on the upstream repo commit history.
-- We could also confirm the SQLite version from the src/common/sqlite3.c file. This file has an amalgamation of the entire SQLite code. On the top comment on this file we can confirm the 3.33.0 version.
After this merge, we applied the needed changes to accommodate the SQLCipher migration.
-- Since we updated SQLCipher from version 3 to 4, it is required that we perform a migration.
-- This is done by executing PRAGMA cipher_migrate; . However, this operation can be costly and should be done only when required.
-- To implement this behaviour, we follow the recommended migration process.
This PR is very complex because it has a lot of changes from upstream. For the reviewers convenience, I'm leaving a reference to the block of code that performs the migration..
-- This was implemented by calling the same method so less code is duplicated.
The entire thought process is described in this comment, from this issue.
Tests
-- Running the sample app as normal;
-- Installing the updated version on top of the old one, to test the migration process;
-- Installing the updated version on top of the updated version, to test the migration did not occured;