Unpin dependencies, update processes for fiona v2.0 #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates: - [github.com/asottile/pyupgrade: v3.3.2 → v3.8.0](asottile/pyupgrade@v3.3.2...v3.8.0) - [github.com/pappasam/toml-sort: v0.23.0 → v0.23.1](pappasam/toml-sort@v0.23.0...v0.23.1) - [github.com/adrienverge/yamllint.git: v1.31.0 → v1.32.0](https://github.com/adrienverge/yamllint.git/compare/v1.31.0...v1.32.0) - [github.com/python-jsonschema/check-jsonschema: 0.22.0 → 0.23.2](python-jsonschema/check-jsonschema@0.22.0...0.23.2)
…ow Python3.11 in conda, use sphinx-rtd-theme
Zeitsperre
added
bug
huard
approved these changes
Jul 6, 2023
…ix `pytest.mark` on certain tests, add `pytest.mark.very_slow` for Manicouagan tests, adjust process code for clarity/maintainability
<!--pre-commit.ci start--> updates: - [github.com/asottile/pyupgrade: v3.3.2 → v3.8.0](asottile/pyupgrade@v3.3.2...v3.8.0) - [github.com/pappasam/toml-sort: v0.23.0 → v0.23.1](pappasam/toml-sort@v0.23.0...v0.23.1) - [github.com/adrienverge/yamllint.git: v1.31.0 → v1.32.0](https://github.com/adrienverge/yamllint.git/compare/v1.31.0...v1.32.0) - [github.com/python-jsonschema/check-jsonschema: 0.22.0 → 0.23.2](python-jsonschema/check-jsonschema@0.22.0...0.23.2) <!--pre-commit.ci end-->
Zeitsperre
added a commit
that referenced
this pull request
Aug 17, 2023
## Overview Changes: * Removed pin on `owslib` below v0.29 and pin on `fiona` below v2.0. * Added a GitHub Workflow to test against macOS builds. * Adapted zonal statistics processes to support the latest `fiona` and `zonalstats` API changes. ## Related Issue / Discussion Now that we've significantly refactored everything, the GIS functionality could be totally rewritten to be much cleaner. I'm tempted to split them into a GIS-focused library (as I had envisioned for `RavenGIS`). This library could be shared between RavenWPS and RavenPy and would offer a much more dynamic method of calling GeoServer, running reprojections, transformations, etc. This would also remove the need to maintain these functions in two places. Will look into this soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes:
owslibbelow v0.29 and pin onfionabelow v2.0.fionaandzonalstatsAPI changes.Related Issue / Discussion
Now that we've significantly refactored everything, the GIS functionality could be totally rewritten to be much cleaner. I'm tempted to split them into a GIS-focused library (as I had envisioned for
RavenGIS).This library could be shared between RavenWPS and RavenPy and would offer a much more dynamic method of calling GeoServer, running reprojections, transformations, etc. This would also remove the need to maintain these functions in two places.
Will look into this soon.
Additional Information
Links to other issues or sources.