Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Raven Docker Image, pin Pandas below v2.0 #466

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Conversation

Zeitsperre
Copy link
Contributor

Overview

Changes:

  • Updated base to Python3.8
  • Updated docker image to use condaforge/mambaforge and mamba
  • Set Debian/Ubuntu image frontend settings to "noninteractive"

Related Issue / Discussion

Additional Information

Links to other issues or sources.

@Zeitsperre Zeitsperre added Ouranos dependencies Pull requests that update a dependency file labels Apr 4, 2023
@Zeitsperre Zeitsperre requested a review from tlvu April 4, 2023 16:15
@Zeitsperre Zeitsperre self-assigned this Apr 4, 2023
@Zeitsperre
Copy link
Contributor Author

@tlvu Tests are failing due to the newest release of Pandas (v2.0) not being compatible with xarray. Should I be fixing that here at the same time?

@tlvu
Copy link
Contributor

tlvu commented Apr 4, 2023

@tlvu Tests are failing due to the newest release of Pandas (v2.0) not being compatible with xarray. Should I be fixing that here at the same time?

Sure why not. Just rename the PR title and description o make it clear you are fixing more than just the docker image.

Thanks for the quick fix.

Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for Docker fix.

@Zeitsperre Zeitsperre changed the title Fix Raven Docker Image Fix Raven Docker Image, pin Pandas below v2.0 Apr 4, 2023
@Zeitsperre Zeitsperre merged commit bf3c8df into master Apr 4, 2023
@Zeitsperre Zeitsperre deleted the fix_docker branch April 4, 2023 17:06
Zeitsperre added a commit that referenced this pull request Aug 17, 2023
## Overview

Changes:

* Updated base to Python3.8
* Updated docker image to use `condaforge/mambaforge` and mamba
* Set Debian/Ubuntu image frontend settings to `"noninteractive"`
* Pins Pandas below v2.0 in multiple locations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Ouranos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants