Use RavenPy v0.11.0 #461
Merged
Use RavenPy v0.11.0 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
added
Ouranos
dependencies
for more information, see https://pre-commit.ci
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…y casting to strings
|
If it works for you, I want to release this version so that we have something stable before I start ripping out a lot of the workarounds to better rewrite some base functions. Some of the changes in fiona will only be valid for one more version (hence the upper limit in fiona) so I want to move onto those soon. |
huard
approved these changes
Feb 24, 2023
Zeitsperre
added a commit
that referenced
this pull request
Aug 17, 2023
## Overview Changes: * Updated several dependencies to be in sync with `ravenpy` v0.11.0 (including `raven-hydro` v3.6) * Updated pre-commit hooks * Modified (workaround) some processes to reflect breaking changes in `fiona` v1.9 * places upper limit below v2.0 * Updated default `pytest-xdist` scheduler to use `worksteal` * Added `MAIN_TESTDATA_BRANCH` as a modifiable env var in main CI workflow ## Related Issue / Discussion The changes in fiona are breaking to `python-rasterstats`. I needed to hack a workaround for fixing the properties out. Much of this logic should be removed when a new version is released. Zonal statistics processes need to be rewritten from the ground up anyway. Other changes stemming from the new fiona popped up in a few other places as well. GIS function in RavenPy need to be torn apart and re-written. Good motivation to continue work on RavenGIS. ## Additional Information perrygeo/python-rasterstats#281 * **The testing branch of raven-testdata must be modified back to `master` before merging** (see: Ouranosinc/raven-testdata#34) * Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Changes:
ravenpyv0.11.0 (includingraven-hydrov3.6)fionav1.9pytest-xdistscheduler to useworkstealMAIN_TESTDATA_BRANCHas a modifiable env var in main CI workflowRelated Issue / Discussion
The changes in fiona are breaking to
python-rasterstats. I needed to hack a workaround for fixing the properties out. Much of this logic should be removed when a new version is released. Zonal statistics processes need to be rewritten from the ground up anyway.Other changes stemming from the new fiona popped up in a few other places as well. GIS function in RavenPy need to be torn apart and re-written. Good motivation to continue work on RavenGIS.
Additional Information
perrygeo/python-rasterstats#281
masterbefore merging (see: Fix encoding of vector data raven-testdata#34)