-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct datetime for some models #453
Conversation
The datetime format of some models data weren't in the good format for the correction manipulation and training. I've managed to correct the issue by transforming the non-standard calendar in numpy.datetime64 which is the desired format. It is now possible to use these models also: CMCC-ESM2, CanESM5, FGOALS-g3, INM-CM4-8 and INM-CM5-0.
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
I suggest using See https://docs.xarray.dev/en/stable/generated/xarray.Dataset.convert_calendar.html |
Changed the conversion with the recommendation of David (using the convert_calendar method of Dataset)
for more information, see https://pre-commit.ci
I've changed the way we convert the calendar and it's working. I pushed it, so a new review would be appreciated. Thanks! |
To give this a chance to get into the next version, I'll wait for @huard's review before preparing the release. |
There are a couple of weird warnings in the nb, can these be fixed ? |
I have the graphics on my side. I'm looking into the odd, Latitude warning. The rest seems to be good |
So the warning for Latitude were from the chosen model, which crashes in the original nb. I switch back to MIROC6 (like in the original) since it doesnt have any odd warning. The other warnings were already in the original nb, but I can look into it in another issue/PR. |
In the tutorial 08_Getting_and_bias_correcting_CMIP6_data, the datetime format of some models weren't in the good format for the data extraction of the desired duration. I've managed to correct the issue by transforming the non-standard calendar in numpy.datetime64 which is the desired format. It is now possible to use these models also: CMCC-ESM2, CanESM5, FGOALS-g3, INM-CM4-8 and INM-CM5-0.
In the tutorial 08_Getting_and_bias_correcting_CMIP6_data, the datetime format of some models weren't in the good format for the data extraction of the desired duration. I've managed to correct the issue by transforming the non-standard calendar in numpy.datetime64 which is the desired format. It is now possible to use these models also: CMCC-ESM2, CanESM5, FGOALS-g3, INM-CM4-8 and INM-CM5-0.