-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paper notebooks #435
Add paper notebooks #435
Conversation
tmp file to create empty folder
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
The location you put your notebooks will not be picked-up by Jenkins, which is intended since you mentioned the notebook will be slow.
As for auto-deploying to the Jupyter env, we can not deploy to writable-workspace
because we do not want to override user's personal changes.
Currently the entire Raven repo is cloned under tutorial-notebooks so once you merge this PR, your new paper notebooks will be available there.
docs/source/notebooks/paper/tmp.txt
Outdated
@@ -0,0 +1 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normal this file is empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, thanks!
OK thanks, looks good! It'll be perfect. I just can't merge, can't seem to override the checks like before. I guess we'll wait for them to finish! |
Hey @tlvu and @richardarsenault, raven requires a new RavenPy release to fix a few things in the dependencies. I'll see if I can push something either today or tomorrow. I'll keep you both posted. |
OK thanks! Appreciate it! |
Looks like @richardarsenault you can merge now. Trevor's RavenPy update will be in a separate PR, unless it is needed by this new notebook. |
This PR adds notebooks and required data for reproducing the case studies in the paper to be published.
This PR adds notebooks and required data for reproducing the case studies in the paper to be published. Ideally it will be made available in users' writable-workspace on the platform.