Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add paper notebooks #435

Merged
merged 3 commits into from
Sep 15, 2022
Merged

Add paper notebooks #435

merged 3 commits into from
Sep 15, 2022

Conversation

richardarsenault
Copy link
Contributor

This PR adds notebooks and required data for reproducing the case studies in the paper to be published. Ideally it will be made available in users' writable-workspace on the platform.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The location you put your notebooks will not be picked-up by Jenkins, which is intended since you mentioned the notebook will be slow.

As for auto-deploying to the Jupyter env, we can not deploy to writable-workspace because we do not want to override user's personal changes.

Currently the entire Raven repo is cloned under tutorial-notebooks so once you merge this PR, your new paper notebooks will be available there.

@@ -0,0 +1 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal this file is empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

@tlvu
Copy link
Contributor

tlvu commented Sep 15, 2022

Current location of already existing Raven notebooks on the Jupyter env below. Your new paper folder will be at the same place.

Screenshot from 2022-09-15 15-14-33

@richardarsenault
Copy link
Contributor Author

OK thanks, looks good! It'll be perfect. I just can't merge, can't seem to override the checks like before. I guess we'll wait for them to finish!

@Zeitsperre
Copy link
Contributor

Hey @tlvu and @richardarsenault, raven requires a new RavenPy release to fix a few things in the dependencies. I'll see if I can push something either today or tomorrow. I'll keep you both posted.

@richardarsenault
Copy link
Contributor Author

OK thanks! Appreciate it!

@tlvu
Copy link
Contributor

tlvu commented Sep 15, 2022

Looks like @richardarsenault you can merge now. Trevor's RavenPy update will be in a separate PR, unless it is needed by this new notebook.

@richardarsenault richardarsenault merged commit cebd522 into master Sep 15, 2022
@richardarsenault richardarsenault deleted the add_paper_notebooks branch September 15, 2022 20:09
@tlvu
Copy link
Contributor

tlvu commented Sep 16, 2022

New paper notebooks deployed to production Jupyter:

Screenshot from 2022-09-16 09-35-33

Zeitsperre pushed a commit that referenced this pull request Aug 17, 2023
This PR adds notebooks and required data for reproducing the case
studies in the paper to be published.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants