Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EnsureGithubDirectiveStartWithPrefix rule with named directive #1676

Merged

Conversation

alamirault
Copy link
Collaborator

@alamirault alamirault commented Mar 12, 2024

There is 16 false-positive on symfony 5.4 branch

For example

components/property_info.rst ✘
  267: Please only use "Symfony" base namespace with Github directive
   ->  :method:`PropertyInfoExtractor::getTypes() <Symfony\\Component\\PropertyInfo\\PropertyInfoExtractor::getTypes>`
  284: Please only use "Symfony" base namespace with Github directive
   ->  The :method:`Type::getBuiltinType() <Symfony\\Component\\PropertyInfo\\Type::getBuiltinType>`
  295: Please only use "Symfony" base namespace with Github directive
   ->  The :method:`Type::isNullable() <Symfony\\Component\\PropertyInfo\\Type::isNullable>`
  303: Please only use "Symfony" base namespace with Github directive
   ->  is ``object``, the :method:`Type::getClassName() <Symfony\\Component\\PropertyInfo\\Type::getClassName>`
  309: Please only use "Symfony" base namespace with Github directive
   ->  The :method:`Type::isCollection() <Symfony\\Component\\PropertyInfo\\Type::isCollection>`
  327: Please only use "Symfony" base namespace with Github directive
   ->  available), via the :method:`Type::getCollectionKeyTypes() <Symfony\\Component\\PropertyInfo\\Type::getCollectionKeyTypes>`
  328: Please only use "Symfony" base namespace with Github directive
   ->  and :method:`Type::getCollectionValueTypes() <Symfony\\Component\\PropertyInfo\\Type::getCollectionValueTypes>`

@OskarStark OskarStark merged commit 7b1192e into OskarStark:develop Mar 13, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants