Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: Ensure link are at the bottom of the file #1542

Merged

Conversation

alamirault
Copy link
Collaborator

Fix #1512

FYI when I run it on Symfony docs I have "only" 2 errors πŸ˜„

frontend/encore/faq.rst ✘
  140: Please move link line at the bottom of the file
   ->  .. _`rsync`: https://rsync.samba.org/
  171: Please move link line at the bottom of the file
   ->  .. _`Webpack integration in PhpStorm`: https://www.jetbrains.com/help/phpstorm/using-webpack.html

contributing/code/conventions.rst ✘
  184: Please move link line at the bottom of the file
   ->  .. _`ServiceRouterLoader`: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php

@OskarStark
Copy link
Owner

Great πŸ‘ŒπŸ»πŸ€“

But I spotted another idea for a new rule:

.. _ServiceRouterLoader: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php

This links to 4.4 and should link to 5.4

@OskarStark
Copy link
Owner

"Please move link definition to the bottom of the page" as error message

@alamirault
Copy link
Collaborator Author

Great πŸ‘ŒπŸ»πŸ€“

But I spotted another idea for a new rule:

.. _ServiceRouterLoader: https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php

This links to 4.4 and should link to 5.4

It can be replaced by {version}. (I will check missing occurences in docs)
Not sure this rule is required now as we don't have this problem on new contributions I think

@OskarStark OskarStark merged commit d30f700 into OskarStark:develop Oct 16, 2023
6 of 8 checks passed
OskarStark added a commit that referenced this pull request Oct 16, 2023
* develop:
  New rule: Ensure link are at the bottom of the file (#1542)
  Use `phpunit/phpunit` 10 (#1541)
  Add `AbstractLineContentRuleTestCase` (#1540)
  Enhancement: Bump dependencies in `composer.json` (#1539)
  Add composer normalize (#1538)
OskarStark added a commit to OskarStark/symfony-docs that referenced this pull request Oct 16, 2023
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Oct 16, 2023
This PR was merged into the 5.4 branch.

Discussion
----------

Use DOCtor-RST 1.53

Leverage
* OskarStark/doctor-rst#1542

Commits
-------

3094be9 Use DOCtor-RST 1.53
@alamirault alamirault deleted the feature/1512-force-link-to-bottom branch October 16, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force link definition to bottom
2 participants