Enhancement: Add ComposerRequireChecker (#1513)

OskarStark · Sep 20, 2023 · 3da6d2a · 3da6d2a
1 parent 8134c7a
commit 3da6d2a
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 3 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -178,3 +178,7 @@ jobs:
             -
                 name: "Check for unused dependencies"
                 run: 'vendor/bin/composer-unused --no-progress --output-format=github | grep -e "^::error" && exit 1 || :'
+
+            -
+                name: "Check for implicit dependencies"
+                run: "tools/composer-require-checker check --config-file=$(pwd)/composer-require-checker.json composer.json"
diff --git a/Makefile b/Makefile
@@ -19,5 +19,6 @@ refactoring:
 	vendor/bin/rector process --config rector.php
 
 .PHONY: dependency-analysis
-dependency-analysis:
+dependency-analysis: vendor ## Runs a dependency analysis with maglnet/composer-require-checker
+	symfony php tools/composer-require-checker check --config-file=$(shell pwd)/composer-require-checker.json
 	vendor/bin/composer-unused
diff --git a/composer-require-checker.json b/composer-require-checker.json
@@ -0,0 +1,22 @@
+{
+    "symbol-whitelist": [
+        "array",
+        "bool",
+        "callable",
+        "dump",
+        "false",
+        "float",
+        "int",
+        "iterable",
+        "mixed",
+        "null",
+        "object",
+        "parent",
+        "self",
+        "static",
+        "string",
+        "true",
+        "void",
+        "never"
+    ]
+}
diff --git a/composer.json b/composer.json
@@ -6,13 +6,15 @@
         "php": "^8.2",
         "ext-ctype": "*",
         "ext-iconv": "*",
+        "ext-mbstring": "*",
         "composer/semver": "^3.4.0",
         "ondram/ci-detector": "^4.1.0",
         "symfony/config": "^6.3.2",
         "symfony/console": "^6.3.4",
         "symfony/dependency-injection": "^6.3.4",
         "symfony/finder": "^6.3.3",
         "symfony/options-resolver": "^6.3.0",
+        "symfony/service-contracts": "^3.3",
         "symfony/string": "^6.3.2",
         "symfony/yaml": "^6.3.3",
         "webmozart/assert": "^1.11"

diff --git a/composer.lock b/composer.lock
diff --git a/phive.xml b/phive.xml
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phive xmlns="https://phar.io/phive">
+  <phar name="composer-require-checker" version="^4.0" installed="4.7.0" location="./tools/composer-require-checker" copy="true"/>
+</phive>
diff --git a/tools/composer-require-checker b/tools/composer-require-checker