Merge pull request #1 from Ordina-Group/expand-create-team

Added privacy and parent team id as additional parameters for creating a team
Ordina-Group · Sep 13, 2023 · 29be8d0 · 29be8d0
2 parents 669ff8c + 7c4646f
commit 29be8d0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/src/main/kotlin/nl/ordina/github/internal/GitHubOrganizationClient.kt b/src/main/kotlin/nl/ordina/github/internal/GitHubOrganizationClient.kt
@@ -32,9 +32,16 @@ internal object GitHubOrganizationClient {
         return request(client).map { it.withOrganization(organizationName) }
     }
 
-    fun createTeam(organizationName: String, teamName: String, description: String?): GitHubTeam {
+    fun createTeam(
+        organizationName: String,
+        teamName: String,
+        description: String? = null,
+        privacy: String = "secret",
+        parentTeamId: Int? = null
+    ): GitHubTeam {
         val lens = Body.auto<GetTeamResponse>().toLens()
-        val request = PostRequest("orgs/$organizationName/teams", CreateTeamRequest(teamName, description))
+        val body = CreateTeamRequest(teamName, description, privacy, parentTeamId)
+        val request = PostRequest("orgs/$organizationName/teams", body)
 
         return lens(client(request)).withOrganization(organizationName)
     }
@@ -109,7 +116,9 @@ internal object GitHubOrganizationClient {
     @Serializable
     internal data class CreateTeamRequest(
         val name: String,
-        val description: String?
+        val description: String? = null,
+        val privacy: String = "secret",
+        val parent_team_id: Int? = null
     )
 
     @Serializable

diff --git a/src/main/kotlin/nl/ordina/github/organization/GitHubOrganization.kt b/src/main/kotlin/nl/ordina/github/organization/GitHubOrganization.kt
@@ -15,8 +15,13 @@ data class GitHubOrganization internal constructor(
 ) {
     fun getTeams(): List<GitHubTeam> = GitHubOrganizationClient.getTeams(login)
 
-    fun createTeam(teamName: String, teamDescription: String? = null): GitHubTeam =
-        GitHubOrganizationClient.createTeam(login, teamName, teamDescription)
+    fun createTeam(
+        teamName: String,
+        teamDescription: String? = null,
+        privacy: String = "secret",
+        parentTeamId: Int? = null
+    ): GitHubTeam =
+        GitHubOrganizationClient.createTeam(login, teamName, teamDescription, privacy, parentTeamId)
 
     fun getRepositories(): List<GitHubRepository> = GitHubOrganizationClient.getRepositories(login)
     fun getMembers(): List<GitHubOrganizationMember> = GitHubOrganizationClient.getMembers(login)