-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore merge from c5f46b0 to 6d24ccc #2159
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels kind of weird to have custom tooltips/popovers with a violet bg even if it underlines the fact that we shouldn't use them. But I'm fine with it anyway.
Few comments to tak into account before merging!
@@ -220,17 +220,18 @@ | |||
|
|||
// scss-docs-start custom-tooltip | |||
.custom-tooltip { | |||
--bs-tooltip-bg: var(--bs-primary); | |||
--bs-tooltip-bg: var(--bd-violet-bg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Bootstrap side] It feels weird to have a reference to bd-
inside our doc.
} | ||
// scss-docs-end custom-tooltip | ||
|
||
// scss-docs-start custom-popovers | ||
.custom-popover { | ||
--bs-popover-max-width: 12.5rem; | ||
--bs-popover-border-color: var(--bs-primary); | ||
--bs-popover-border-color: var(--bd-violet-bg); | ||
--bs-popover-header-bg: var(--bd-violet-bg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Bootstrap side] It feels weird to have a reference to bd-
inside our doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
twbs/bootstrap@9cc85fd: nothing to do since we don't have these vars in Boostedtwbs/bootstrap@7a42268: can't regerenatepackage-lock.json
now since some packages will be updated later on in this PR--bd-primary-*
Boosted-specific to handle the various container colors in the documentation to be orange and not violet.twbs/bootstrap@a70852f: this example doesn't exist in Boosted