refactor(android): rename compose preview functions

Oppzippy · Jul 5, 2023 · 402ec9f · 402ec9f
1 parent 59b5d02
commit 402ec9f
Show file tree

Hide file tree

Showing 18 changed files with 83 additions and 15 deletions.
diff --git a/android/app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/AppInfo.kt b/android/app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/AppInfo.kt
@@ -80,7 +80,7 @@ private fun HtmlText(text: String, modifier: Modifier = Modifier) {
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewAppInfo() {
     OpenSCQ30Theme {
         AppInfo(onBackClick = {})
     }

diff --git a/...oid/app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/DeviceList.kt b/...oid/app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/DeviceList.kt
@@ -42,7 +42,7 @@ fun DeviceList(
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewDeviceList() {
     OpenSCQ30Theme {
         val devices = ArrayList<BluetoothDevice>()
         for (i in 1..100) {

diff --git a/.../app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/DeviceListing.kt b/.../app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/DeviceListing.kt
@@ -86,15 +86,15 @@ fun DeviceListing(
 
 @Preview(showBackground = true)
 @Composable
-private fun NoDevicesFoundPreview() {
+private fun PreviewNoDevicesFound() {
     OpenSCQ30Theme {
         DeviceListing(listOf())
     }
 }
 
 @Preview(showBackground = true)
 @Composable
-private fun DevicesPreview() {
+private fun PreviewDeviceListing() {
     OpenSCQ30Theme {
         val devices = ArrayList<BluetoothDevice>()
         for (i in 1..100) {

diff --git a/...app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/NoDevicesFound.kt b/...app/src/main/java/com/oppzippy/openscq30/ui/deviceselection/composables/NoDevicesFound.kt
@@ -31,7 +31,7 @@ fun NoDevicesFound(modifier: Modifier = Modifier) {
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewNoDevicesFound() {
     OpenSCQ30Theme {
         NoDevicesFound()
     }

diff --git a/.../app/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/DeviceSettings.kt b/.../app/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/DeviceSettings.kt
@@ -103,7 +103,7 @@ fun DeviceSettings(
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewDeviceSettings() {
     OpenSCQ30Theme {
         DeviceSettings(
             uiState = UiDeviceState.Connected(

diff --git a/...id/app/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/Disconnected.kt b/...id/app/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/Disconnected.kt
@@ -28,7 +28,7 @@ fun Disconnected() {
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewDisconnected() {
     OpenSCQ30Theme {
         Disconnected()
     }

diff --git a/android/app/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/Loading.kt b/android/app/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/Loading.kt
@@ -28,7 +28,7 @@ fun Loading() {
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewLoading() {
     OpenSCQ30Theme {
         Loading()
     }

diff --git a/...p/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/SoundModeSettings.kt b/...p/src/main/java/com/oppzippy/openscq30/ui/devicesettings/composables/SoundModeSettings.kt
@@ -96,7 +96,7 @@ private fun LabeledRadioButton(text: String, selected: Boolean, onClick: () -> U
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewSoundModeSettings() {
     OpenSCQ30Theme {
         SoundModeSettings(
             ambientSoundMode = AmbientSoundMode.Normal,

diff --git a/...rc/main/java/com/oppzippy/openscq30/ui/equalizer/composables/CreateCustomProfileDialog.kt b/...rc/main/java/com/oppzippy/openscq30/ui/equalizer/composables/CreateCustomProfileDialog.kt
@@ -12,8 +12,10 @@ import androidx.compose.runtime.remember
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.tooling.preview.Preview
 import com.oppzippy.openscq30.R
 import com.oppzippy.openscq30.ui.equalizer.storage.CustomProfile
+import com.oppzippy.openscq30.ui.theme.OpenSCQ30Theme
 
 @Composable
 fun CreateCustomProfileDialog(
@@ -57,3 +59,21 @@ fun CreateCustomProfileDialog(
         )
     }
 }
+
+@Preview(showBackground = true)
+@Composable
+private fun PreviewCreateCustomProfileDialog() {
+    OpenSCQ30Theme {
+        CreateCustomProfileDialog(
+            isOpen = true,
+            onDismiss = {},
+            onCreateCustomProfile = {},
+            existingProfiles = listOf(
+                CustomProfile(
+                    "Test Profile",
+                    listOf(1, 2, 3, 4, 5, 6, 7, 8),
+                ),
+            ),
+        )
+    }
+}
diff --git a/...p/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/CustomProfileSelection.kt b/...p/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/CustomProfileSelection.kt
@@ -2,8 +2,10 @@ package com.oppzippy.openscq30.ui.equalizer.composables
 
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.tooling.preview.Preview
 import com.oppzippy.openscq30.R
 import com.oppzippy.openscq30.ui.equalizer.storage.CustomProfile
+import com.oppzippy.openscq30.ui.theme.OpenSCQ30Theme
 
 @Composable
 fun CustomProfileSelection(
@@ -22,3 +24,16 @@ fun CustomProfileSelection(
         onItemSelected = onProfileSelected,
     )
 }
+
+@Preview(showBackground = true)
+@Composable
+private fun PreviewCustomProfileSelection() {
+    val selectedProfile = CustomProfile("Test Profile", listOf(0, 10, 20, 30, 40, 50, 60, 70))
+    OpenSCQ30Theme {
+        CustomProfileSelection(
+            selectedProfile = selectedProfile,
+            profiles = listOf(selectedProfile),
+            onProfileSelected = {},
+        )
+    }
+}
diff --git a/...rc/main/java/com/oppzippy/openscq30/ui/equalizer/composables/DeleteCustomProfileDialog.kt b/...rc/main/java/com/oppzippy/openscq30/ui/equalizer/composables/DeleteCustomProfileDialog.kt
@@ -5,7 +5,9 @@ import androidx.compose.material3.Button
 import androidx.compose.material3.Text
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.tooling.preview.Preview
 import com.oppzippy.openscq30.R
+import com.oppzippy.openscq30.ui.theme.OpenSCQ30Theme
 
 @Composable
 fun DeleteCustomProfileDialog(
@@ -39,3 +41,16 @@ fun DeleteCustomProfileDialog(
         )
     }
 }
+
+@Preview(showBackground = true)
+@Composable
+private fun PreviewDeleteCustomProfileDialog() {
+    OpenSCQ30Theme {
+        DeleteCustomProfileDialog(
+            isOpen = true,
+            profileName = "Test Profile",
+            onDelete = {},
+            onDismiss = {},
+        )
+    }
+}
diff --git a/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/Dropdown.kt b/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/Dropdown.kt
@@ -60,7 +60,7 @@ fun <T> Dropdown(
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewDropdown() {
     OpenSCQ30Theme {
         var value by remember { mutableStateOf(1) }
         Dropdown(

diff --git a/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/Equalizer.kt b/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/Equalizer.kt
@@ -49,7 +49,7 @@ fun Equalizer(
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewEqualizer() {
     var values by remember { mutableStateOf(listOf<Byte>(0, 0, 0, 0, 0, 0, 0, 0)) }
     OpenSCQ30Theme {
         Equalizer(

diff --git a/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/EqualizerLine.kt b/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/EqualizerLine.kt
@@ -70,7 +70,7 @@ fun EqualizerLine(values: List<Byte>, width: Dp, height: Dp) {
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewEqualizerLine() {
     val values by remember { mutableStateOf(listOf<Byte>(0, 10, 120, 0, -10, -120, 0, 0)) }
     OpenSCQ30Theme {
         EqualizerLine(values = values, width = 80.dp, height = 20.dp)

diff --git a/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/EqualizerSlider.kt b/android/app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/EqualizerSlider.kt
@@ -67,7 +67,7 @@ fun EqualizerSlider(
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewEqualizerSlider() {
     OpenSCQ30Theme {
         EqualizerSlider(hz = 100, value = 0, onValueChange = {}, text = "0", onTextChange = {})
     }

diff --git a/...p/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/PresetProfileSelection.kt b/...p/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/PresetProfileSelection.kt
@@ -46,7 +46,7 @@ fun PresetProfileSelection(
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewPresetProfileSelection() {
     OpenSCQ30Theme {
         var profile by remember { mutableStateOf(EqualizerProfile.Classical) }
         PresetProfileSelection(value = profile, onProfileSelected = {

diff --git a/.../app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/ProfileSelectionRow.kt b/.../app/src/main/java/com/oppzippy/openscq30/ui/equalizer/composables/ProfileSelectionRow.kt
@@ -37,7 +37,7 @@ fun ProfileSelectionRow(name: String, volumeAdjustments: List<Byte>?) {
 
 @Preview(showBackground = true)
 @Composable
-private fun DefaultPreview() {
+private fun PreviewProfileSelectionRow() {
     OpenSCQ30Theme {
         ProfileSelectionRow(
             name = "Test Profile",

diff --git a/...c/main/java/com/oppzippy/openscq30/ui/equalizer/composables/ReplaceCustomProfileDialog.kt b/...c/main/java/com/oppzippy/openscq30/ui/equalizer/composables/ReplaceCustomProfileDialog.kt
@@ -19,9 +19,11 @@ import androidx.compose.runtime.Composable
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.res.stringResource
+import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
 import com.oppzippy.openscq30.R
 import com.oppzippy.openscq30.ui.equalizer.storage.CustomProfile
+import com.oppzippy.openscq30.ui.theme.OpenSCQ30Theme
 
 @OptIn(ExperimentalMaterial3Api::class)
 @Composable
@@ -71,3 +73,19 @@ fun ReplaceCustomProfileDialog(
         }
     }
 }
+
+@Preview(showBackground = true)
+@Composable
+private fun PreviewReplaceCustomProfileDialog() {
+    OpenSCQ30Theme {
+        ReplaceCustomProfileDialog(
+            isOpen = true,
+            profiles = listOf(
+                CustomProfile("Test Profile 1", listOf(0, -10, 20, 30, 40, 50, 60, 70)),
+                CustomProfile("Test Profile 2", listOf(-50, -20, 30, 40, 50, 60, 70, 80)),
+            ),
+            onDismiss = {},
+            onProfileSelected = {},
+        )
+    }
+}