Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC*Pausable warning for public pausing mechanism #4007

Merged
merged 10 commits into from
Jan 28, 2023

Conversation

ernestognw
Copy link
Member

Mitigates #4006, although it doesn't solve, makes it clear that there are missing functions.

@changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2023

🦋 Changeset detected

Latest commit: 2a86021

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
openzeppelin-solidity Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ernestognw ernestognw changed the title Add erc20 pausable warning Add ERC20Pausable warning for public pausing mechanism Jan 27, 2023
Amxx
Amxx previously approved these changes Jan 27, 2023
@Amxx Amxx requested a review from frangio January 27, 2023 09:48
@frangio
Copy link
Contributor

frangio commented Jan 27, 2023

This needs to be applied in ERC721Pausable and ERC1155Pausable as well.

@ernestognw
Copy link
Member Author

This needs to be applied in ERC721Pausable and ERC1155Pausable as well.

Thanks for the heads up. I added them with the same message proposed.

@ernestognw ernestognw changed the title Add ERC20Pausable warning for public pausing mechanism Add ERC*Pausable warning for public pausing mechanism Jan 28, 2023
frangio
frangio previously approved these changes Jan 28, 2023
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

.changeset/new-ways-own.md Outdated Show resolved Hide resolved
Co-authored-by: Francisco <fg@frang.io>
@frangio frangio merged commit 1684c57 into OpenZeppelin:master Jan 28, 2023
frangio pushed a commit that referenced this pull request Jan 31, 2023
Co-authored-by: Francisco <fg@frang.io>
(cherry picked from commit 1684c57)
@ernestognw ernestognw deleted the add-erc20-pausable-warning branch February 15, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants