Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added organization as git sub module #7

Merged
merged 2 commits into from
Apr 30, 2019

Conversation

0xsarvesh
Copy link
Collaborator

@0xsarvesh 0xsarvesh commented Apr 24, 2019

fixes #3

This PR adds organization repo as a git submodule in this repo. I have initialized truffle project to get directory structure (contracts/organization), but didn't update truffle config(there is separate ticket)

To pull code for submodule use git submodule init.
To update the code for submodule use git submodule update --recursive

@schemar
Copy link
Contributor

schemar commented Apr 24, 2019

Let's wait and see what path we agree on here OpenST/organization-contracts#6 (comment)

@abhayks1
Copy link
Collaborator

Reviewing this...

@abhayks1 abhayks1 self-assigned this Apr 25, 2019
Copy link
Collaborator

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯
Added few comments inline.

contracts/truffle/Migrations.sol Show resolved Hide resolved
.gitmodules Show resolved Hide resolved
@abhayks1 abhayks1 assigned abhayks1 and unassigned abhayks1 Apr 25, 2019
Copy link
Contributor

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐶

Copy link
Contributor

@schemar schemar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use git-submodules to include organization contracts
5 participants