Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSTComposer StakeRequest object storage optimization #778

Merged
merged 5 commits into from
Jun 26, 2019
Merged

OSTComposer StakeRequest object storage optimization #778

merged 5 commits into from
Jun 26, 2019

Conversation

abhayks1
Copy link
Contributor

@abhayks1 abhayks1 commented Jun 25, 2019 •
edited
Loading

  • stakeRequests mapping has been updated to
    mapping(bytes32 => bool) public stakeRequests

  • StakeRequest objects contract's storage optimization

  • Below method interfaces has been updated so that stakeRequestHash can be calculated:

    • acceptStakeRequest()
    • revokeStakeRequest()
    • rejectStakeRequest()

Please see detailed gas analysis in the ticket.

Fixes #770

@puneet-khushwani-eth puneet-khushwani-eth self-assigned this Jun 25, 2019
@puneet-khushwani-eth
Copy link

Reviewing.

puneet-khushwani-eth
puneet-khushwani-eth reviewed Jun 25, 2019
View reviewed changes
Copy link

@puneet-khushwani-eth puneet-khushwani-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍 Have a small question, which I have added inline.

contracts/test/gateway/TestOSTComposer.sol Show resolved Hide resolved
contracts/test/gateway/TestOSTComposer.sol Show resolved Hide resolved
@puneet-khushwani-eth puneet-khushwani-eth removed their assignment Jun 25, 2019
@deepesh-kn deepesh-kn self-assigned this Jun 26, 2019
deepesh-kn
deepesh-kn approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor

@deepesh-kn deepesh-kn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

contracts/gateway/OSTComposer.sol Outdated Show resolved Hide resolved
@deepesh-kn deepesh-kn removed their assignment Jun 26, 2019
@abhayks1
Copy link
Contributor Author

Travis is green 📗 Available for review 🐮

@deepesh-kn deepesh-kn merged commit 9ec44b4 into OpenST:develop Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneet-khushwani-eth puneet-khushwani-eth puneet-khushwani-eth left review comments

@deepesh-kn deepesh-kn deepesh-kn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop storing StakeRequest object in OSTComposer contract's storage
3 participants
@abhayks1 @puneet-khushwani-eth @deepesh-kn