Destructing staker proxy via ost composer contract #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgev
suggested changes
Jun 25, 2019
| @@ -0,0 +1,49 @@ | |||
| // Copyright 2019 OpenST Ltd. | |||
There was a problem hiding this comment.
I would propose to test the followings in addition:
- That contract was actually
selfdestruct -ed. (web3.eth.getCode(address) can be helpful I would assume). - That remaining
etherwas sent to the owner.
There was a problem hiding this comment.
We can add contract code assertion, to ensure that selfdestruct is called. Asserting ether will be more like testing solidity selfdestruct works fine or not. Also, I don't think this contract can hold ether. There is not payable function.
There was a problem hiding this comment.
I've thought, like this:
we do: selfdestruct(owner) and we want to test that, and not that we do selfdestruct() or selfdestruct(non-owner-address). What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #771
This PR updates the flow of self-destructing staker proxy contract. With this PR, staker(owner) can call
destructStakerProxyon composer contract.This PR also delete ComposerInterface used in stakerProxy contract as there is no method call from staker proxy to composer.