Implements a fuzzer that generates the valid Merkel Patricia Proofs. #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 8, 2019 09:39
Resolves: OpenST#716 See also: OpenST#718, OpenST#719
Fixes failing test cases after linter error cleanup. Replaces string usages by Buffer.
- .gitignore ignores generated files from typescript files.
- MerklePatriciaProof::verify and MerklePatriciaProof::verifyDebug
functions uses toData instead of toBytes during comparsion agaist
value.
- Improved pattern validity to correctly handle ending branch node.
- Fixed an issue with branch, extension and leaf nodes
serialization.
- .travis.yml runs fuzzy_proof_generator tests.
benjaminbollen
suggested changes
May 13, 2019
| @@ -129,7 +129,7 @@ library MerklePatriciaProof { | |||
|
|
|||
| if(currentNodeList.length == 17) { | |||
| if(pathPtr == path.length) { | |||
| if(keccak256(abi.encodePacked(RLP.toBytes(currentNodeList[16]))) == value) { | |||
| if(keccak256(abi.encodePacked(RLP.toData(currentNodeList[16]))) == value) { | |||
There was a problem hiding this comment.
this PR, focused on tests, should not contain changes to the implementation
schemar
reviewed
May 13, 2019
added 7 commits
May 13, 2019 14:27
In addition, contains the followings:
- Store values in rlp encoding.
- Introduces sanity tests for FuzzyProofGenerator::generate
and FuzzyProofGenerator::generateByPattern functions.
- Adds run.sh script to run FuzzyProofGenerator tests.
- Updates .travis.yml to run FuzzyProofGenerator tests.
In addition, within './tools/fuzzy_proof_generator_tool/test/run.sh' tests are disabled as currently failing.
pgev
changed the title
benjaminbollen
approved these changes
May 14, 2019
There was a problem hiding this comment.
I haven't reviewed in full; but removing my veto on changes to the MPP library.
- good that we keep MPP in original form first; it might very well be valid change to align
toBytesortoData, but let's do so after further analysis and deliberation - good that path is now generated by the fuzzer
|
Reviewing 🦑 |
schemar
suggested changes
May 16, 2019
There was a problem hiding this comment.
As always, really good work @pgev, thank you! 🐙
It is quite a big PR and I hope I didn't miss anything. I took the time to do a proper review. A lot of my comments are "maybe"s and questions. Feel free to disregard those.
See all feedback in-line.
tools/fuzzy_proof_generator_tool/test/Util/nibblesToBuffer.test.ts
Outdated
Show resolved
Hide resolved
- Fixes a bug in FuzzyProofGenerator::processExtension() function.
- Moves Util::encodeCompactExtensionNode() function to
ExtensionNode::encodeCompact().
- Moves Util::encodeCompactLeafNode() function to
LeafNode::encodeCompact().
- Moves Util::generateRandomKeccak256 function to
FuzzyProofGenerator::generateRandomKeccak256().
- Moves nibbles related functionality from Util.ts to NibblesUtil.ts.
- Removes Util.ts.
- Improves documentation for low-level bitwise operations
within NibblesUtil.ts.
- assert.throws() instances check against a specific error message.
- Enhances generateByPattern test suites.
- Fixes lint errors for tools/fuzzy_proof_generator ts files.
- Checks "proof_generation" dir within `npm run lint`.
- Disables eslint @typescript-eslint/camelcase" rule.
- Adds .eslintignore file.
- Updates dev dependencies within package.json.
pgev
commented
May 17, 2019
tools/fuzzy_proof_generator_tool/test/FuzzyProofGenerator/assertPatternValidity.test.ts
Show resolved
Hide resolved
tools/fuzzy_proof_generator_tool/test/FuzzyProofGenerator/generateByPattern.js
Show resolved
Hide resolved
added 3 commits
May 17, 2019 16:58
- Renames NibblesUtil to Nibbles.
- Fixes bugs and stronger requirement checks for
FuzzyProofGenerator::generateByPattern().
- Enhances code documentation and comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #716
See also: #718, #719