Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated proof data should retain its pattern #754

Closed
schemar opened this issue May 22, 2019 · 0 comments · Fixed by #760
Closed

Generated proof data should retain its pattern #754

schemar opened this issue May 22, 2019 · 0 comments · Fixed by #760

Comments

@schemar
Copy link
Contributor

schemar commented May 22, 2019

Story

As a developer
I want to know which pattern caused an MPP library test to fail
Because it helps me debug the case

Scenario

Given that I run the MPP.verify unit tests
When a test based on the data from the fuzzy proof generator fails
Then the message should include the pattern
Instead it currently only contains the arguments to verify

Info

TODO: When generating and storing the proof data with the fuzzy generator in ./tools/fuzzy_proof_generator_tool/generate.ts, also store the pattern that was used to generate the proof in the generated JSON file.

That should be all, as the assert message in ./test/lib/merkle_patricia_proof.js already contains data, which now contains the pattern.

ℹ️ This is a follow-up to #743 and #751

@pgev pgev self-assigned this May 29, 2019
pgev pushed a commit to pgev/mosaic-contracts that referenced this issue May 29, 2019
@pgev pgev removed their assignment Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants