Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves metadata from pyproject.toml #525

Merged

Conversation

maurerle
Copy link
Contributor

Summary of the discussion

improves metadata from pyproject.toml

  • supported python versions are implicitly generated from requires-python
  • license identifier makes license better visible, as it uses the common term on the https://pypi.org/project/open-mastr/ page.

Workflow checklist

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

- supported python versions are implicit generated from requires-python
- license identifier makes license better visible
@FlorianK13
Copy link
Member

Thanks @maurerle for this PR. We were not too familiar with the pyproject.toml syntax when we recently replaced our setup.py, so these simplifications look great. I'll test it within this week.

@FlorianK13
Copy link
Member

Tests are failing since API credentials are not provided for PRs coming from outside. I will merge anyway and rely on the tests that run before the next release.

@FlorianK13 FlorianK13 merged commit 0afff46 into OpenEnergyPlatform:develop May 28, 2024
0 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants