Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 521 fix documentation #523

Merged
merged 3 commits into from
May 24, 2024
Merged

Feature 521 fix documentation #523

merged 3 commits into from
May 24, 2024

Conversation

FlorianK13
Copy link
Member

Workflow checklist

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@FlorianK13 FlorianK13 marked this pull request as ready for review May 24, 2024 06:15
@FlorianK13 FlorianK13 requested a review from chrwm May 24, 2024 06:15
chrwm
chrwm approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@chrwm chrwm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for incorporating the JOSS feedback!

@FlorianK13 FlorianK13 merged commit ffea4d5 into develop May 24, 2024
9 checks passed
@FlorianK13 FlorianK13 deleted the feature-521-fix-documentation branch May 24, 2024 10:28
This was referenced May 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrwm chrwm chrwm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianK13 @chrwm