Re-work of the network manager #533

jeremypoulter · 2023-01-29T22:16:36Z

This is a rework of the code to manage connecting to the network, WiFi or Wired. This code better manages the state we are in so hopefully there are less issues and is also more agressive at staying connected to the WiFi access point.

Fixes #420, fixes #460

All network changes are now handled in the main network loop and also added in some state management. For Wired boards we try to connect only on wired for a period of time before bringing up the WiFi. In AP mode, if we have client credentials continuosly try to connect the client. Auto stop the AP after a successful client connection

Evaluate the state on startup to make sure the IP subsystems are initialised. Only restart the WiFi on disconnect if we are not connected via a wired connection. Fixes to the random seed to work on ESP32 (kind of, not really needed)

Hopefully will help with MQTT connections

KipK · 2023-01-31T19:35:38Z

Does the wifi module switch now to AP + STA when wifi has been configured and previous mode was AP ?
I still have to finish the Wizard when this is ok

jeremypoulter · 2023-01-31T21:32:04Z

Going to do some work cleaning up the endpoints based on this and I will work on that area then

glynhudson · 2023-02-13T14:24:32Z

Hi @jeremypoulter I've just done some testing and noticed that when a long press on the front push button is used to force the module to create a WiFi AP captive portal is not active.

To clarify: when the push button is pressed and help for about 5s the WiFi AP gets created, but the module remains connected to the existing Wifi network and the Wifi AP does not activate a captive portal when a user connects.

jeremypoulter · 2023-02-13T14:31:52Z

Will take a look

KipK · 2023-02-21T07:04:20Z

I'm testing this now, and making change to UI wizard ( moving to /config endpoint )
When I set the Wifi + Pass while in AP mode, I see in the log it's looping in reconnection until Wifi module is rebooted or soft AP client is disconnected
After we reboot the Wifi module, it then goes in Client only and works ok:

Connecting to SSID: WifiNetwrk
Got Network event ARDUINO_EVENT_WIFI_STA_START
WiFi State AccessPointConnecting
WiFi Mode AP+STA
Set host name to openevse-c6cd
Got Network event ARDUINO_EVENT_WIFI_STA_DISCONNECTED
WiFi State AccessPointConnecting
WiFi Mode AP+STA
WiFi dissconnected: WIFI_DISCONNECT_REASON_NO_AP_FOUND
Got Network event ARDUINO_EVENT_WIFI_STA_STOP
WiFi State AccessPointConnecting
WiFi Mode AP
Connecting to SSID: WifiNetwrk
Got Network event ARDUINO_EVENT_WIFI_STA_START
WiFi State AccessPointConnecting
WiFi Mode AP+STA
Set host name to openevse-c6cd
Got Network event ARDUINO_EVENT_WIFI_STA_DISCONNECTED
WiFi State AccessPointConnecting
WiFi Mode AP+STA
WiFi dissconnected: WIFI_DISCONNECT_REASON_NO_AP_FOUND
Got Network event ARDUINO_EVENT_WIFI_STA_STOP
WiFi State AccessPointConnecting
WiFi Mode AP
Connecting to SSID: WifiNetwrk
Got Network event ARDUINO_EVENT_WIFI_STA_START
WiFi State AccessPointConnecting
WiFi Mode AP+STA
Set host name to openevse-c6cd
Got Network event ARDUINO_EVENT_WIFI_STA_DISCONNECTED
WiFi State AccessPointConnecting
WiFi Mode AP+STA
WiFi dissconnected: WIFI_DISCONNECT_REASON_NO_AP_FOUND
Got Network event ARDUINO_EVENT_WIFI_STA_STOP
WiFi State AccessPointConnecting
WiFi Mode AP

I think it keep the softAP channel when connecting as STA instead of changing channel.

KipK · 2023-02-21T07:34:10Z

Other thing I have here, when scanning for network while in AP mode, It gives one time a result, then scanning again always return empty array.
Doesn't happened in CLI mode

jeremypoulter · 2023-02-21T21:54:44Z

@glynhudson I think I have resolved that issue, please can you check again

@KipK I think the connection issue you are seeing is expected behaviour. The configured SSID is not found (WIFI_DISCONNECT_REASON_NO_AP_FOUND) so we keep on retrying.

I also can not reproduce the AP scanning issue, looks to work for me.

KipK · 2023-02-22T06:20:12Z

@jeremypoulter the esp is 3 meters from the AP. signal is strong.
It just doesn't connect to the wifi router until the ESP leave AP mode.
At reboot it also instantaneously connect to the router. I think ESP32 should switch channel to the router channel when connecting in AP+STA mode. ( My wifi is channel 13 here, ESP seems to always be on lower channels in AP mode )

It found it at first scan in AP mode then all the other results return the same ( either empty or a network in the lower band channel ). Scan works ok in STA mode.

I've tried to debug that yesterday without success. Also tryied using WiFiManager lib on the same dev ESP and had no such problem.

KipK · 2023-02-22T07:11:17Z

more info on this, first scan takes few seconds to answer and gives full result. Second scan and all following ones instantaneously ( doesn't seem to scan really ) and always gives the same result thereafter ( can be empty or few networks around the same channel )

KipK · 2023-02-22T07:19:47Z

I have submitted a PR on your branch allowing to restart mDNS at hostname change jeremypoulter#17

KipK · 2023-02-22T12:02:36Z

so has discussed in pv, seems scanning in passive mode solve the scan issue.

I now see another problem now since I've moved to passive scan, wonder if I'm alone. When in AP mode, wifi not configured yet, when saving the wifi / pass on /config endpoint, I'm kicked out of the AP, AP seems disabled then and the ESP module don't connect to the WiFi network until I powercycle.

edit: If I comment the second scan at the end of the function:
//if(WiFi.scanComplete() == -2){ //WiFi.scanNetworks(true, false, true); //}
it stills disable AP when setting the wifi, but for the first time I receive the new IP, that's a good thing! I can at least redirect the page to new ip when device has reconnected to main wifi.

Other thing, when esp is in STA+AP and connected correctly to the wifi router, the IP adress from the /status endpoint is still AP one (192.168.4.1)
But I can reach the wifi module from its home network ip too.

glynhudson · 2023-02-22T12:26:13Z

Hi @jeremypoulter I've just done some testing and noticed that when a long press on the front push button is used to force the module to create a WiFi AP captive portal is not active.

To clarify: when the push button is pressed and help for about 5s the WiFi AP gets created, but the module remains connected to the existing Wifi network and the Wifi AP does not activate a captive portal when a user connects.

Hi @jeremypoulter, I've just tested this PR again and this issue remains the same. When the push button is held for 10s to force the module to create a WiFi AP this WiFi AP does not have a captive portal. When I connect to the AP, my phone just says "no internet' and doest not give a captive portal option to sign in:

jeremypoulter · 2023-02-22T12:44:59Z

Oh I see, I fixed an issue with the AP not starting at all...

…n completes Uses the scan complete event so not to block the firmware

…ter/ESP32_WiFi_V4.x into wifi_connection-issue

…net cable connected

scan all channels before connecting to AP ( needed for above )

KipK · 2023-02-25T15:13:01Z

When the push button is held for 10s to force the module to create a WiFi AP this WiFi AP does not have a captive portal.

@glynhudson , beware, 10sec is for factory resetting the esp not just set in ap mode. It's 2 sec for AP only

@jeremypoulter , got one little issue left, if I throw AP mode with the button, while already connected to STA ( switchting to AP+STA) the ipaddress in /status takes 192.168.4.1 instead of STA one.

jeremypoulter · 2023-02-25T16:22:35Z

@KipK I think, that is correct, the user has explicitly changed to AP mode, so they would want to know the IP to then connect to. Technically the ESP has two IPs, maybe we could return both, but I think that can be done separately.

KipK · 2023-02-25T16:54:28Z

then other apps/ui/home automation connected to the api will also receive this new ip , but the evse is still connected to the network and works normally.

As it's more a process of maintenance, I don't think there's need to override the current ip by the AP one. Not sure there's a real use in redirecting UI to AP ip in this case
In AP only mode that is different.

KipK · 2023-02-25T17:54:56Z

this jeremypoulter@f7b1009 fix @glynhudson captive portal not showing problem

Some network changes ( missing push event at IP change, Active scan, connect best signal AP )

…ter/ESP32_WiFi_V4.x into wifi_connection-issue

KipK · 2023-02-27T14:02:37Z

I've submitted you the compile fix, sorry for that.

jeremypoulter#20

fix compile

jeremypoulter · 2023-02-27T21:50:18Z

Thanks, I knew I should have waited for those builds to finish ;-)

jeremypoulter · 2023-02-28T22:31:25Z

@glynhudson can you test this again?

KipK · 2023-03-07T14:43:53Z

Are we good for mergin it ?
I don't see any other issues than the one already fixed.

glynhudson · 2023-03-08T19:19:29Z

Great, just tested. Working now, thanks a lot 👍

jeremypoulter added 12 commits June 21, 2022 22:29

Attempt to fix weird WiFi connection issue (WIP)

ea13ea3

Merge branch 'master' into wifi_connection-issue

6785553

Fix merge mistake

694467a

Initial rework to change update the network stack to a MicroTask

8d16553

Removed MicroTask debug

c5778d9

A few bugfixes

16248d0

Evaluate the state on startup to make sure the IP subsystems are initialised. Only restart the WiFi on disconnect if we are not connected via a wired connection. Fixes to the random seed to work on ESP32 (kind of, not really needed)

Fixed setting the time

5447f06

A few more bugfixes and tweaks

5214caa

Disable sleep

95de203

Hopefully will help with MQTT connections

Merge branch 'master' into wifi_connection-issue

12cfbff

Use the latest Microtasks release with new features

c8e4fe9

jeremypoulter added 2 commits February 21, 2023 19:33

Merge branch 'master' into wifi_connection-issue

4854238

Fix for starting up the the AP when already connected to a WiFi network

ba7119e

restart mDNS when hostname has changed

9b903e6

jeremypoulter and others added 2 commits February 22, 2023 21:47

Updated the WiFi Scanning code to block the web request while the sca…

0d68d7b

…n completes Uses the scan complete event so not to block the firmware

Merge branch 'wifi_connection-issue' of https://github.com/jeremypoul…

f47a7fe

…ter/ESP32_WiFi_V4.x into wifi_connection-issue

KipK and others added 6 commits February 23, 2023 10:09

restart mDNS when hostname has changed

467e149

removed static function , restart also _dnsServer

b3a0aa0

Merge branch 'master' into wifi_connection-issue

6c9417b

Fixed some issues starting the WiFi on an ESP32 Gateway with no ether…

82847db

…net cable connected

Merge branch 'master' into wifi_connection-issue

784d454

force wifi to connect to AP with best signal

e40ac2a

scan all channels before connecting to AP ( needed for above )

jeremypoulter mentioned this pull request Feb 25, 2023

Multi-access point: weakest signal chosen #385

Closed

KipK added 3 commits February 25, 2023 14:41

fix setting in wrong function

bd5b22b

remove dns restart

88b29df

restart network stack at hostname change if no AP

12a5b5c

remove restart network task at hostname change

2e5e593

fix Captive portal not showing in AP+STA mode

f7b1009

KipK and others added 4 commits February 26, 2023 09:47

use isWifiModeAp

4242971

Merge pull request #17 from KipK/wifi_connection-issue

7968d38

Some network changes ( missing push event at IP change, Active scan, connect best signal AP )

fix compile

85cd826

Merge branch 'wifi_connection-issue' of https://github.com/jeremypoul…

3ee4a29

…ter/ESP32_WiFi_V4.x into wifi_connection-issue

Merge pull request #20 from KipK/wifi_connection-issue

0537e30

fix compile

glynhudson merged commit aa7fab5 into OpenEVSE:master Mar 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-work of the network manager #533

Re-work of the network manager #533

jeremypoulter commented Jan 29, 2023 •

edited

Loading

KipK commented Jan 31, 2023

jeremypoulter commented Jan 31, 2023

glynhudson commented Feb 13, 2023 •

edited

Loading

jeremypoulter commented Feb 13, 2023

KipK commented Feb 21, 2023 •

edited

Loading

KipK commented Feb 21, 2023 •

edited

Loading

jeremypoulter commented Feb 21, 2023

KipK commented Feb 22, 2023 •

edited

Loading

KipK commented Feb 22, 2023 •

edited

Loading

KipK commented Feb 22, 2023

KipK commented Feb 22, 2023 •

edited

Loading

glynhudson commented Feb 22, 2023

jeremypoulter commented Feb 22, 2023

KipK commented Feb 25, 2023 •

edited

Loading

jeremypoulter commented Feb 25, 2023

KipK commented Feb 25, 2023 •

edited

Loading

KipK commented Feb 25, 2023

KipK commented Feb 27, 2023

jeremypoulter commented Feb 27, 2023

jeremypoulter commented Feb 28, 2023

KipK commented Mar 7, 2023

glynhudson commented Mar 8, 2023

Re-work of the network manager #533

Re-work of the network manager #533

Conversation

jeremypoulter commented Jan 29, 2023 • edited Loading

KipK commented Jan 31, 2023

jeremypoulter commented Jan 31, 2023

glynhudson commented Feb 13, 2023 • edited Loading

jeremypoulter commented Feb 13, 2023

KipK commented Feb 21, 2023 • edited Loading

KipK commented Feb 21, 2023 • edited Loading

jeremypoulter commented Feb 21, 2023

KipK commented Feb 22, 2023 • edited Loading

KipK commented Feb 22, 2023 • edited Loading

KipK commented Feb 22, 2023

KipK commented Feb 22, 2023 • edited Loading

glynhudson commented Feb 22, 2023

jeremypoulter commented Feb 22, 2023

KipK commented Feb 25, 2023 • edited Loading

jeremypoulter commented Feb 25, 2023

KipK commented Feb 25, 2023 • edited Loading

KipK commented Feb 25, 2023

KipK commented Feb 27, 2023

jeremypoulter commented Feb 27, 2023

jeremypoulter commented Feb 28, 2023

KipK commented Mar 7, 2023

glynhudson commented Mar 8, 2023

jeremypoulter commented Jan 29, 2023 •

edited

Loading

glynhudson commented Feb 13, 2023 •

edited

Loading

KipK commented Feb 21, 2023 •

edited

Loading

KipK commented Feb 21, 2023 •

edited

Loading

KipK commented Feb 22, 2023 •

edited

Loading

KipK commented Feb 22, 2023 •

edited

Loading

KipK commented Feb 22, 2023 •

edited

Loading

KipK commented Feb 25, 2023 •

edited

Loading

KipK commented Feb 25, 2023 •

edited

Loading