Quick and dirty filter to ensure no >127 chars are sent over the websocket and hense valid UTF-8 is sent #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocket and hense valid UTF-8 is sent On a quick scan there does not look to be a readily avalible library for ASCII to UTF-8 conversion, so as we don't have all that many cases where this is an issue, basically just the space on the LCD, just a quick hack to ensure valid UTF-8 is sent
|
Works fine here thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a quick scan there does not look to be a readily avalible library for ASCII to UTF-8 conversion, so as we don't have all that many cases where this is an issue, basically just the space on the LCD, just a quick hack to ensure valid UTF-8 is sent.
Fixes #509