improvment & fixes of MQTT /override topic #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed useless if condition
KipK
changed the title
fix override topic not publishing props if there's no state prop removed useless if condition
| @@ -445,6 +439,12 @@ unsigned long EvseManager::loop(MicroTasks::WakeReason reason) | |||
| { | |||
| _evaluateTargetState = false; | |||
| setTargetState(_targetProperties); | |||
|
|
|||
There was a problem hiding this comment.
I am not super keen on this, will leave it for now but we need to consider how to make this more generic, I would prefer not to have these special cases in the EVSE manager... We probably need to give the clients text names and event them all or something like that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add auto_release to /override
fix override publication missed on mqtt
fix mqtt /override topic publishing too much props