Add some events through websocket & mqtt #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Do not commit yet. I have to test this first |
|
ok all good to me. It push over websocket / mqtt amp/voltage when charging each sec like for the lcd |
|
Also added a fix for a little bug with Pilot I have spotted . It was hidden in the middle of all the /status poll traffic |
KipK
force-pushed
the
events
branch
2 times, most recently
from
f5b5b82
to
774dbbb
Compare
Event Amp & Voltage sent each sec while charging event sessions each 2 sec while charging
refactored handleStatus function # Conflicts: # src/web_server.cpp
|
Damn I've messed the rebase again.... refixing.... |
|
When this will be merge, we will be able to remove the /status polling on actual UI too. |
|
it's ok. But I can resubmit a proper rebased pull request if you want. |
jeremypoulter
approved these changes
Oct 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussed here #401 (comment)
Add missing events over web socket / mqtt
Send full status data over web socket when new client connect
fix Pilot event bug