Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #187 - Feed watchdog in http_update_write() & ESP Ethernet OTA upload #415

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

ianrrees
Copy link
Contributor

@ianrrees ianrrees commented Aug 11, 2022

I've only spent a couple minutes testing this on an ESP32-PoE-ISO board, but it seems to work, and it compiles OK for the targets on the releases page.

Fixes #187

Updates over ethernet were failing because the Mongoose poll() method
wasn't exiting for the duration of the firmware upload.
@jeremypoulter
Copy link
Collaborator

Thanks for the contribution, I will check it out

@ianrrees
Copy link
Contributor Author

Thank you for identifying the problem! I'm hoping to look at upgrading Mongoose this weekend.

There is something strange going on with the relationship between WiFi and Ethernet that I don't fully understand yet. I think maybe the issue is if the WiFi is connected, and ethernet too, sometimes things get in to a bad state - I've just been erasing the whole flash to nuke the saved WiFi info. Probably not worth digging too deep before a big networking change anyway.

@ianrrees
Copy link
Contributor Author

Also, just to be clear, I don't think this really fixes the underlying problem - it's just a hacky fix for that one symptom. Really, the networking stuff shouldn't block the main loop for so long. Haven't had a chance to look at the current version of Mongoose yet, but perhaps it provides a nice way to resolve that issue. Or, I believe the ESP32 Arduino framework is actually running FreeRTOS under the hood, it might be more effective to have the OS handle the lower-level networking stuff.

@jeremypoulter
Copy link
Collaborator

Looks to work well.

@jeremypoulter jeremypoulter merged commit ed00306 into OpenEVSE:master Aug 22, 2022
@glynhudson glynhudson changed the title Issue #187 - Feed watchdog in http_update_write() Issue #187 - Feed watchdog in http_update_write() & ESP Ethernet OTA upload Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP update failes on ESP32 Etherent gateway
2 participants