Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to improve the (re)loading of the GUI after update #221

Merged
merged 2 commits into from
Jul 26, 2021

Conversation

jeremypoulter
Copy link
Collaborator

@jeremypoulter jeremypoulter commented Jul 24, 2021

Various changes that should fix #220

  • changed the caching to use ETag, the date format for the Last-Modified header was wrong and was a bit brute force. Using ETag allows proper caching of the each individual file, even over firmware updates.
  • added the Cache-Control header, to force the browser to check with the WiFi module if the file hase changed before using a cached version.
  • reload the GUI after successful firmware update

Note: these changes will only help after upgrading to a firmware with these fixes.

The date format for the Last-Modified header was wrong and was a bit brute force. Using ETag allows proper caching of the each individual file, even over firmware updates.

Also added the Cache-Control header, to force the browser to check with the WiFi module if the file hase changed before using a cached version.
@glynhudson glynhudson merged commit 4b00f92 into master Jul 26, 2021
@glynhudson glynhudson deleted the jeremypoulter/issue220 branch July 26, 2021 15:30
@glynhudson
Copy link
Collaborator

Nice work, I've just tested. The GUI didn't seem to automatically reload after updating, however when I manually reloaded the page didn't hang 👍

However, I was updating from V4.1.0 beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page hanges on first load after updating to latest version
2 participants