Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTP not automatically working #194

Closed
glynhudson opened this issue Jun 4, 2021 · 3 comments
Closed

NTP not automatically working #194

glynhudson opened this issue Jun 4, 2021 · 3 comments
Assignees
@jeremypoulter
Labels
bug Something isn't working

Comments

@glynhudson
Copy link
Collaborator

Many hours after a power outage I noticed the time on the EVSE was incorrect. NTP was enabled and setup correctly. The unit required me to click 'Set Time' to force an NTP update to correct the time:

Screenshot 2021-06-04 03 54 26

FW: V4.0.1
@glynhudson glynhudson added the bug Something isn't working label Jun 4, 2021
@rvoosterhout
Copy link

I have had the same issue. NTP didn't update the time directly. If I use the browser method, it does change the time, but after 2 seconds it changes the time 2 hours in the past.

@jeremypoulter
Copy link
Collaborator

This potentially could be related to #212, can you re-test after merging?

@jeremypoulter
Copy link
Collaborator

No ignore that, been able to reproduce...

jeremypoulter added a commit that referenced this issue Jul 24, 2021
@jeremypoulter
Only update to the EVSE time if later than the ESP32 time.
e59151e 
On making a connection to the EVSE we read the time as the EVSE module may have a battery backed RTC or even just it has remained on during reboot.

However it also may not have a useful time set, eg when recovering from a power cut and no battery backed RTC. In ths case there is a race condition between getting the time from NTP and the time from the EVSE. So now we only set to the EVSE time if it is later than the local ESP time.

This fixes NTP not automatically working  #194.
@jeremypoulter jeremypoulter mentioned this issue Jul 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeremypoulter jeremypoulter

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glynhudson @jeremypoulter @rvoosterhout