Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for parsing numeric hue values #65

Merged
merged 5 commits into from
Aug 3, 2024
Merged

Fix for parsing numeric hue values #65

merged 5 commits into from
Aug 3, 2024

Conversation

OpenBagTwo
Copy link
Owner

@OpenBagTwo OpenBagTwo commented Jul 18, 2024 •
edited
Loading

Fixes the parsing bug identified in #61

To Do

Add example config files to Wiki

Validation performed

  • Tests now cover numeric hues
  • I've tested these changes with my own config files

@OpenBagTwo
TDD: Repro #61
3f43401 
Note that JSON spec is the only spec that works
@OpenBagTwo
Fix #61
6ca939b
@OpenBagTwo OpenBagTwo linked an issue Jul 18, 2024 that may be closed by this pull request
Example Format for Spec Config File #61
Open
@OpenBagTwo
Copy link
Owner Author

I have no idea why pre-commit is fine with my code but running actual mypy standalone is not, but the type errors I'm seeing make no sense given that the code doesn't, like, blow up, so I'm just going to disable the mypy part of the lint checker job for now.

@OpenBagTwo OpenBagTwo merged commit 059d386 into 1.21 Aug 3, 2024
5 checks passed
@OpenBagTwo OpenBagTwo deleted the rpg-config-fix branch August 3, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example Format for Spec Config File
1 participant
@OpenBagTwo