Fix Resourcepack Generator #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think I'm looking at going to mkdocs
Read: alphabetically
tbf, only most of this was my fault--it looks like Minecraft 1.19.3 is a lot stricter in terms of where it will look for textures.
|
There may be some sense in upping the pack format when building on the 1.19.3 branch, but as long as it's possible to create a resource pack that is compatible with all supported versions of the game, I'd rather just have users deal with the warning than think they need to use a special version of the executable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd love to blame this on a bug? in Minecraft 1.19.3's resource resolver but the truth it that it was pretty obvious that I never tested even once that the zip files were valid resourcepacks.